Skip to content

[ES-2411C] - [Step4] Convert consentmgmt/db from sqlc to hand-written sqlx - #2757

Open
KashiwalHarsh wants to merge 1 commit into
mosip:develop-gofrom
Infosys:ES-2411C
Open

KashiwalHarsh wants to merge 1 commit into
mosip:develop-gofrom
Infosys:ES-2411C

Conversation

@KashiwalHarsh

Copy link
Copy Markdown
Collaborator

Stacked on #<ES-2411 https://github.com/mosip/esignet/pull/2682> — do not review/merge until that merges.
This branch is cut from ES-2411, so the diff currently also includes its commits (~23 files) and shows merge conflicts. Only the Phase 4 commit (consentmgmt/db sqlx conversion, 12 files) is new here. Once # merges into develop-go, I'll rebase this onto the updated develop-go → it drops to the 12 Phase-4 files and the conflicts clear, then I'll mark it Ready for review.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 20 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI; Enforced overrides: Organization
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 912c71e6-55db-42a9-aa6d-92b530613c23
Commits

Reviewing files that changed from the base of the PR and between e6029d3 and da8d2d2.

Files selected for processing: 13

  • esignet-service/cmd/esignet/main.go
  • esignet-service/go.mod
  • esignet-service/internal/consentmgmt/db/db.go
  • esignet-service/internal/consentmgmt/db/db_test.go
  • esignet-service/internal/consentmgmt/db/models.go
  • esignet-service/internal/consentmgmt/db/querier.go
  • esignet-service/internal/consentmgmt/db/query.sql
  • esignet-service/internal/consentmgmt/db/query.sql.go
  • esignet-service/internal/consentmgmt/db/schema.sql
  • esignet-service/internal/consentmgmt/service.go
  • esignet-service/internal/consentmgmt/service_test.go
  • esignet-service/internal/engine/consent_provider_test.go
  • esignet-service/sqlc.yaml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Signed-off-by: Harsh Kashiwal <harsh.kashiwal@infosys.com>
@KashiwalHarsh
KashiwalHarsh marked this pull request as ready for review November 5, 2026 08:06
@codecov-commenter

codecov-commenter commented Nov 5, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 54.76190% with 19 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop-go@e6029d3). Learn more about missing BASE report.

Files with missing lines Patch % Lines
esignet-service/internal/consentmgmt/db/db.go 46.66% 16 Missing ⚠️
esignet-service/internal/consentmgmt/service.go 81.81% 2 Missing ⚠️
esignet-service/cmd/esignet/main.go 0.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@              Coverage Diff              @@
##             develop-go    #2757   +/-   ##
=============================================
  Coverage              ?   80.20%           
=============================================
  Files                 ?      136           
  Lines                 ?     8649           
  Branches              ?      181           
=============================================
  Hits                  ?     6937           
  Misses                ?     1680           
  Partials              ?       32           
Flag Coverage Δ
go 79.25% <54.76%> (?)
npm 92.85% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants