Repository navigation
fix(s3): treat a 404 from a single-key delete as already deleted - #60
Merged
kamilmysliwiec merged 1 commit intoNov 9, 2026
Merged
Conversation
Google Cloud Storage answers DeleteObject for a key that doesn't exist with 404 NoSuchKey, where S3 answers 204. delete() of a missing key, which is documented not to be an error, failed there with a StorageServiceError, for every single-key delete and for every key with batchDelete: false. A 404 for a missing key is now ignored; other errors, such as NoSuchBucket, still fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
delete()is documented as "Deleting a missing key is not an error". On S3,DeleteObjectanswers 204 for a missing key. Google Cloud Storage's XML API, whichS3Disklists as a supported store (endpoint: 'https://storage.googleapis.com',batchDelete: false), answers404 NoSuchKeyinstead.S3Diskturns that into aStorageServiceError, so on GCS:This affects every single-key delete, which always goes through
DeleteObject, and every key whenbatchDeleteisfalse.Issue Number: N/A
What is the new behavior?
DeleteObjectmaps a 404 for the key to "not found" the same wayget()andstat()do, anddeleteObjects()ignores it, because the key is already gone. Other errors,NoSuchBucketincluded, still fail.Does this PR introduce a breaking change?
Other information