Repository navigation
perf(PageService): don't read full subpage tree for cleaning subpage order - #2172
Merged
Merged
Conversation
…order No need to create PageInfo objects for all subpages just to get their pageIds. This improves the memory footprint of `cleanSubpageOrder()`. Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/subpage_order_cleanup_performance
branch
from
December 22, 2025 21:05
e4e342c to
2f4e82a
Compare
silverkszlo
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need to create PageInfo objects for all subpages just to get their pageIds. This improves the memory footprint of
cleanSubpageOrder().🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)