Skip to content

perf(PageService): don't read full subpage tree for cleaning subpage order - #2172

Merged
mejo- merged 1 commit into
mainfrom
fix/subpage_order_cleanup_performance
Dec 23, 2025
Merged

mejo- merged 1 commit into
mainfrom
fix/subpage_order_cleanup_performance

Conversation

@mejo-

@mejo- mejo- commented Dec 22, 2025

Copy link
Copy Markdown
Member

No need to create PageInfo objects for all subpages just to get their pageIds. This improves the memory footprint of cleanSubpageOrder().

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

…order

No need to create PageInfo objects for all subpages just to get their
pageIds. This improves the memory footprint of `cleanSubpageOrder()`.

Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
mejo- force-pushed the fix/subpage_order_cleanup_performance branch from e4e342c to 2f4e82a Compare December 22, 2025 21:05
@mejo-
mejo- merged commit 9c7c2f1 into main Dec 23, 2025
52 of 54 checks passed
@mejo-
mejo- deleted the fix/subpage_order_cleanup_performance branch December 23, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants