Skip to content

fix(sharing): prevent editable share links when editing is restricted - #2883

Merged
mejo- merged 2 commits into
mainfrom
fix/admin_only_edit_no_editable_shares
Oct 21, 2026
Merged

mejo- merged 2 commits into
mainfrom
fix/admin_only_edit_no_editable_shares

Conversation

@mejo-

@mejo- mejo- commented Oct 20, 2026

Copy link
Copy Markdown
Member

If editing a collective is limited to admins or moderators, share links are always view only. Previously, an admin could still request an editable share link. This granted edit permissions on the underlying folder share, while the Collectives share silently stayed view only.

Reject such requests in the backend, disable the "Can edit" option and show a note in the sharing sidebar tab explaining why.

Fixes: #2844

Assisted-by: ClaudeCode:claude-opus-5-5

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

@mejo- mejo- self-assigned this Oct 20, 2026
@mejo- mejo- added bug Something isn't working 3. to review feature: sharing labels Oct 20, 2026
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Oct 20, 2026
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Oct 20, 2026
@mejo-
mejo- force-pushed the fix/admin_only_edit_no_editable_shares branch 2 times, most recently from 62c247a to d6ebb05 Compare October 20, 2026 15:19
If editing a collective is limited to admins or moderators, share links
are always view only. Previously, an admin could still request an
editable share link. This granted edit permissions on the underlying
folder share, while the Collectives share silently stayed view only.

Reject such requests in the backend, disable the "Can edit" option and
show a note in the sharing sidebar tab explaining why.

Fixes: #2844

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: ClaudeCode:claude-opus-5-5
@mejo-
mejo- force-pushed the fix/admin_only_edit_no_editable_shares branch from 31f3d1d to e4f7261 Compare October 21, 2026 11:04
… focus

The viewer activates its focus trap after the opening animation. A click
into the editor before that can lose focus to the templates dialog or to
the first viewer button. Retry clicking until the editor keeps focus.

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: ClaudeCode:claude-opus-5-5
@mejo-
mejo- merged commit b078062 into main Oct 21, 2026
64 checks passed
@mejo-
mejo- deleted the fix/admin_only_edit_no_editable_shares branch October 21, 2026 11:39
@github-project-automation github-project-automation Bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

Public share link with edit permission not possible with certain collective settings

2 participants