Repository navigation
fix(sharing): prevent editable share links when editing is restricted - #2883
Merged
Merged
Conversation
mejo-
force-pushed
the
fix/admin_only_edit_no_editable_shares
branch
2 times, most recently
from
October 20, 2026 15:19
62c247a to
d6ebb05
Compare
blizzz
approved these changes
Oct 21, 2026
If editing a collective is limited to admins or moderators, share links are always view only. Previously, an admin could still request an editable share link. This granted edit permissions on the underlying folder share, while the Collectives share silently stayed view only. Reject such requests in the backend, disable the "Can edit" option and show a note in the sharing sidebar tab explaining why. Fixes: #2844 Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
mejo-
force-pushed
the
fix/admin_only_edit_no_editable_shares
branch
from
October 21, 2026 11:04
31f3d1d to
e4f7261
Compare
… focus The viewer activates its focus trap after the opening animation. A click into the editor before that can lose focus to the templates dialog or to the first viewer button. Retry clicking until the editor keeps focus. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If editing a collective is limited to admins or moderators, share links are always view only. Previously, an admin could still request an editable share link. This granted edit permissions on the underlying folder share, while the Collectives share silently stayed view only.
Reject such requests in the backend, disable the "Can edit" option and show a note in the sharing sidebar tab explaining why.
Fixes: #2844
Assisted-by: ClaudeCode:claude-opus-5-5
🖼️ Screenshots
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)