Repository navigation
Publish feature/respect page selection - #2916
Conversation
2e529b9 to
5b61d59
Compare
- StaticSiteContentCollector now only collects selected pages, their ancestors, and their attachments, instead of the whole collective - StaticSiteService resolves and adds missing ancestor page IDs so a subpage can never be selected without its parent pages - CollectivePublishModal auto-selects a page's parent pages when the page itself is selected, keeping selection state consistent with the backend's hierarchy requirement Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: kayoshi <jo5cha@web.de>
5b61d59 to
f1fa170
Compare
Hidden entries are never pages, so they can't be (de)selected in the UI. Publishing them anyway contradicts "only selected content is published" and leaked things like .DS_Store, .obsidian/ or .git/ that members added from outside. Attachment folders stay the only exception; the dedicated .templates check becomes redundant and now also applies to nested folders. Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: kayoshi <jo5cha@web.de>
…odal A page moved since the last publication could show up checked while its parent was not. The backend already pulls in the ancestors on publish, so do the same when loading the stored selection to keep the dialog consistent with what gets published. Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: kayoshi <jo5cha@web.de>
Instead of hard-coding the `.attachments.` prefix, the static site collector uses NodeHelper to build and parse attachment folder names. A folder only counts as attachment folder if its suffix is a numeric page ID now. Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: kayoshi <jo5cha@web.de>
Replace the remaining hard-coded `.attachments.` prefixes. The page ID mock in the NodeHelper test returned a string, the real `getId()` returns an int. Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: kayoshi <jo5cha@web.de>
Walking up the page hierarchy is generic tree logic, not modal-specific, and can now be reused. The existing pageParentsForCollective can't serve this: it stops at the currently opened collective's root page, so its result depends on which collective is passed in. Name it after the backend's "ancestors" wording, since it returns all ancestors, not just the parent. Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: kayoshi <jo5cha@web.de>
Cover attachments of the index page of a subpage folder, a selection whose ancestors are resolved out of order, the ancestor lookup in the pages store and selecting/deselecting pages in the publish modal. Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: kayoshi <jo5cha@web.de>
…tent Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: kayoshi <jo5cha@web.de>
Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: kayoshi <jo5cha@web.de>
109d034 to
298482f
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |

ancestors, and their attachments, instead of the whole collective
subpage can never be selected without its parent pages
page itself is selected, keeping selection state consistent with
the backend's hierarchy requirement