Repository navigation
fix(ui): load priority inbox sections when their initial sync is locked - #13847
Conversation
|
Thank you for the patch |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Hi @GretaD, friendly ping on this one. It still merges cleanly onto main. Let me know if you'd like anything changed or tested. The failing |
| }) | ||
| } | ||
|
|
||
| this.loadingCacheInitialization = false |
There was a problem hiding this comment.
logic is correct, but on the error path loadingCacheInitialization stays
true; harmless since v-if="error" wins, but a finally resetting it would be cleaner.
|
Please rebase and fix the conflicts, and deliver the small comment i left. Thank you again |
e56fd34 to
1e8a1bc
Compare
|
Rebased onto main and moved the reset into a |
|
Could someone approve the workflow runs? They're waiting since the rebase on Thursday. Thanks. |
On the first open of the priority inbox, the Important and Other sections initialize the same uncached INBOX in parallel. The loser gets MailboxLockedError, which syncEnvelopes deliberately rethrows for an initial sync (d572d04) so the component can load the messages instead. initializeCache never did: it only loaded after a successful sync and wasn't awaited, so the section kept spinning or stayed hidden. Await the sync, fall back to loading the messages when the folder is locked, and let other errors reach the existing error state. The parallel syncs themselves are left as they are. Fixes nextcloud#13846 Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Joachim Nolten <joachim@nolten.org>
1e8a1bc to
1456026
Compare
On the first open of the priority inbox, the Important and Other sections initialize the same uncached INBOX in parallel. The loser gets
MailboxLockedError, whichsyncEnvelopesdeliberately rethrows for an initial sync (d572d04) so the component can load the messages instead.initializeCachenever did: it only loaded after a successful sync and wasn't awaited, so the section kept spinning or stayed hidden.Solution: Await the sync, fall back to loading the messages when the folder is locked, and let other errors reach the existing error state. The parallel syncs themselves are left as they are.
Fixes #13846
Assisted-by: Claude:claude-opus-5-5
🤖 AI (if applicable)