Repository navigation
[stable5.13] fix(deeplink): encode message-id as base64url for deep links - #14264
Merged
Merged
Conversation
backportbot
Bot
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
November 20, 2026 13:30
ChristophWurst
approved these changes
Nov 20, 2026
RFC 5322 permits characters in Message-IDs (such as slashes, quotes, etc., commonly seen in GitHub notifications or Bugzilla/GitLab messages) that are problematic in URL paths. When generating a deep link in the Unified Search provider (mail.deep_link.open) or copying a direct link, Symfony's UrlGenerator threw an InvalidParameterException or web servers failed to route slashes. Encode Message-IDs using URL-safe base64url via a Base64Url helper in the search provider and envelope menu, and decode it in DeepLinkController::open(). Unencoded Message-IDs are still accepted for backwards compatibility by checking for the mandatory '@' symbol. If a message lacks a Message-ID, the search provider falls back to the direct thread link. Fixes #13970 Signed-off-by: SoleroTG <github-29h@solero.quietmail.eu>
ChristophWurst
force-pushed
the
backport/14023/stable5.13
branch
from
November 20, 2026 17:08
4fa57af to
c47b1da
Compare
ChristophWurst
enabled auto-merge
November 20, 2026 17:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #14023