Repository navigation
chore(tests): apply rector - #14266
Merged
Merged
Conversation
Base64UrlTest, added in #14023, was not final, which fails the FinalizeTestCaseClassRector check on main. Assisted-by: ClaudeCode:claude-sonnet-5-5 Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
Contributor
|
Merge in 2w (with all other new findings) or now? |
kesselb
approved these changes
Nov 20, 2026
Member
Author
|
I like to read All checks have passed 😎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fresh
mainfails the rector check:Base64UrlTestshould befinal(FinalizeTestCaseClassRector). The test was added in #14023, merged on 2026-11-20. Linked only to explain the timing.Approach
Ran
composer rectoron currentmain. It changes one file: the test class is nowfinal. Nothing else.Testing
Ran
composer rector. It reports no further changes after the fix. I did not run the test suite, as the change is only a class modifier.AI assistance
Assisted by ClaudeCode:claude-sonnet-5-5