Skip to content

chore(tests): apply rector - #14266

Merged
ChristophWurst merged 1 commit into
mainfrom
chore/rector-main
Nov 20, 2026
Merged

ChristophWurst merged 1 commit into
mainfrom
chore/rector-main

Conversation

@ChristophWurst

Copy link
Copy Markdown
Member

Context

Fresh main fails the rector check: Base64UrlTest should be final (FinalizeTestCaseClassRector). The test was added in #14023, merged on 2026-11-20. Linked only to explain the timing.

Approach

Ran composer rector on current main. It changes one file: the test class is now final. Nothing else.

Testing

Ran composer rector. It reports no further changes after the fix. I did not run the test suite, as the change is only a class modifier.

AI assistance

Assisted by ClaudeCode:claude-sonnet-5-5

Base64UrlTest, added in #14023, was not final, which fails the FinalizeTestCaseClassRector check on main.

Assisted-by: ClaudeCode:claude-sonnet-5-5
Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
@ChristophWurst ChristophWurst self-assigned this Nov 20, 2026
@nextcloud-command nextcloud-command added the AI assisted This PR contains AI-assisted commits label Nov 20, 2026
@ChristophWurst
ChristophWurst marked this pull request as ready for review November 20, 2026 17:15
@kesselb

kesselb commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Merge in 2w (with all other new findings) or now?

@ChristophWurst

Copy link
Copy Markdown
Member Author

I like to read All checks have passed 😎

@ChristophWurst
ChristophWurst merged commit 30ab45c into main Nov 20, 2026
51 checks passed
@ChristophWurst
ChristophWurst deleted the chore/rector-main branch November 20, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review AI assisted This PR contains AI-assisted commits enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants