Repository navigation
Conversation
govulncheck alerts Replace the github.com/docker/docker SDK with the standalone github.com/moby/moby/client and github.com/moby/moby/api modules for `nctl get build --pull-image`. This drops the docker/docker and moby/moby +incompatible modules and replaces the mix of docker/docker and moby/moby imports in build.go with the two split modules. - Create the client with client.New(client.FromEnv). API version negotiation is now the default. - Encode registry auth with authconfig.Encode. - Render pull progress with jsonmessage.DisplayMessages over the response's message iterator, which handles terminal detection and closing the stream. - Adapt ImageTag calls to the new ImageTagOptions API. Behaviour is unchanged: the image is still pulled through the local Docker daemon and tagged as :latest and :<build-name>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the github.com/docker/docker SDK with the standalone github.com/moby/moby/client and github.com/moby/moby/api modules for
nctl get build --pull-image. This drops the docker/docker and moby/moby +incompatible modules and replaces the mix of docker/docker and moby/moby imports in build.go with the two split modules.Behaviour is unchanged: the image is still pulled through the local Docker daemon and tagged as :latest and :.