Skip to content
This repository was archived by the owner on Nov 7, 2026. It is now read-only.

Fix binary plus calls and file age comparison in README - #10

Open
yegor256 wants to merge 1 commit into
masterfrom
7
Open

yegor256 wants to merge 1 commit into
masterfrom
7

Conversation

@yegor256

@yegor256 yegor256 commented Nov 7, 2026

Copy link
Copy Markdown
Member

The file-age example supplies three operands to binary plus and tests now + 5h30m > utime, which classifies nearly every file as too old. Nest two binary additions and compare now > utime + 5h30m. The explanation now states that exactly 5h30m counts as fresh.

Closes #7. Only README.md changes; the nanosecond example in #6 remains separate.

Validation: an external indentation-based check reproduced the three-operand failure before the change, then verified binary arity and fresh, exactly 5h30m-old, older, and future timestamp cases after it. git diff --check passes. Master contains only README.md, with no Maven project or workflow runs, so no EO runtime or full-build claim is made. Global local pre-commit checks report pre-existing README formatting and missing REUSE metadata; these remain visible and unchanged. Submitted through GitHub's commit API without changing hook configuration.

Subsequent PR/CI work remains with the existing eo-time maintenance wishes. Sync with master and gh-merge a green, conflict-free head immediately without reviews; never Rultor.

Copilot AI balanced review requested due to automatic review settings November 7, 2026 00:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

@yegor256

yegor256 commented Nov 7, 2026

Copy link
Copy Markdown
Member Author

The README branch is current with master and conflict-free, but its head has no check runs, commit statuses, or workflow runs, so the requested green-CI merge condition is not met. @yegor256, CI availability is the blocker; draft workflow PR #9 remains with its Maven CI owner. A successor wish will finish #10 once head CI is green.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README example passes three arguments to the two-argument plus

2 participants