Repository navigation
Conversation
|
Issue #2 |
|
@yegor256 hello, please take a look |
| @@ -0,0 +1,2 @@ | |||
| # This is the main time object that provides access to all time-related functionality | |||
| [] > time | |||
There was a problem hiding this comment.
The directory is named org.eolang, a single folder with a dot in its name. Issue #2 asks for src/main/eo/org/eolang/time.eo, two nested folders. Please move the file there.
| @@ -0,0 +1,2 @@ | |||
| # This is the main time object that provides access to all time-related functionality | |||
There was a problem hiding this comment.
The file has no +package org.eolang meta line, so the object will not land in the org.eolang package. Please add +package org.eolang (and the +home and +version metas used in other objectionary repositories) above the comment, separated by an empty line.
|
|
||
| <properties> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <eo.version>0.29.0</eo.version> |
There was a problem hiding this comment.
eo-runtime is pinned to 0.29.0, while eo-maven-plugin is 0.58.3. The runtime and the plugin must share one version, otherwise the transpiled Java code will not compile against the runtime. Please use ${eo.version} for the plugin too and set it to 0.58.3 (or the latest release).
| </plugin> | ||
| </plugins> | ||
| </build> | ||
| </project> No newline at end of file |
There was a problem hiding this comment.
The file has no newline at the end. Please add one.
|
@uchitsa, dependency assessment is tracked in #8, assigned to @yegor256 for the Java baseline decision. Please keep #4 and draft #5 aligned: #4 now uses one EO 0.58.3 property, while #5 still mixes runtime 0.29.0 and plugin 0.58.3. After #4 lands, please carry that shared version into #5 when rebasing. EO 0.63.2 raises runtime bytecode to Java 17, so the current Java 11 target needs a decision before that paired upgrade. Structure and CI remain with their existing work; no competing scaffold or dependency PR has been opened. |
|
@uchitsa, focused workflow CI is in #9 (draft until #4 provides the Maven project). It proposes |
No description provided.