Repository navigation
Update proxy_handler to resolve literal string warning - #356
Merged
Merged
Conversation
While running, we encountered a number of warnings: ``` /usr/local/bundle/gems/puffing-billy-4.0.2/lib/billy/handlers/proxy_handler.rb:93: warning: literal string will be frozen in the future (run with --debug-frozen-string-literal for more information) ``` This appears to be due to the force_encoding of the response string. The fix it to dup the response to ensure it's no longer frozen and then apply the encoding.
Collaborator
|
@bwillis thanks for the contribution! can you take a look at the CI failures? |
Contributor
Author
There were some issues in the pipeline and running locally. I made some adjustments and removed the webdriver gem, which seems favorable given that it's deprecated. I think it's working now 🤞 |
Collaborator
|
thanks @bwillis, that did it! I'll cut a new release this week. |
Contributor
Author
Thank you! |
Collaborator
|
Published in 4.0.3 |
Contributor
Author
Thanks again! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While running, we encountered a number of warnings:
This appears to be due to the force_encoding of the response string. The fix it to dup the response to ensure it's no longer frozen and then apply the encoding.