Skip to content

Update proxy_handler to resolve literal string warning - #356

Merged
ronwsmith merged 5 commits into
oesmith:masterfrom
bwillis:patch-1
Jan 18, 2026
Merged

ronwsmith merged 5 commits into
oesmith:masterfrom
bwillis:patch-1

Conversation

@bwillis

@bwillis bwillis commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

While running, we encountered a number of warnings:

/usr/local/bundle/gems/puffing-billy-4.0.2/lib/billy/handlers/proxy_handler.rb:93: warning: literal string will be frozen in the future (run with --debug-frozen-string-literal for more information)

This appears to be due to the force_encoding of the response string. The fix it to dup the response to ensure it's no longer frozen and then apply the encoding.

While running, we encountered a number of warnings:
```
/usr/local/bundle/gems/puffing-billy-4.0.2/lib/billy/handlers/proxy_handler.rb:93: warning: literal string will be frozen in the future (run with --debug-frozen-string-literal for more information)
```

This appears to be due to the force_encoding of the response string. The fix it to dup the response to ensure it's no longer frozen and then apply the encoding.
@ronwsmith

Copy link
Copy Markdown
Collaborator

@bwillis thanks for the contribution! can you take a look at the CI failures?

@bwillis

bwillis commented Jan 16, 2026

Copy link
Copy Markdown
Contributor Author

@bwillis thanks for the contribution! can you take a look at the CI failures?

There were some issues in the pipeline and running locally. I made some adjustments and removed the webdriver gem, which seems favorable given that it's deprecated. I think it's working now 🤞

@ronwsmith

Copy link
Copy Markdown
Collaborator

thanks @bwillis, that did it! I'll cut a new release this week.

@ronwsmith
ronwsmith merged commit d2166d7 into oesmith:master Jan 18, 2026
9 of 10 checks passed
@bwillis

bwillis commented Jan 19, 2026

Copy link
Copy Markdown
Contributor Author

thanks @bwillis, that did it! I'll cut a new release this week.

Thank you!

@ronwsmith

Copy link
Copy Markdown
Collaborator

Published in 4.0.3

@bwillis

bwillis commented Jan 23, 2026

Copy link
Copy Markdown
Contributor Author

Published in 4.0.3

Thanks again! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants