Skip to content

Do not require Identifiable to be Serializable - #74

Merged
BalusC merged 1 commit into
developfrom
fix/73-identifiable-not-serializable
Nov 3, 2026
Merged

Do not require Identifiable to be Serializable#74
BalusC merged 1 commit into
developfrom
fix/73-identifiable-not-serializable

Conversation

@BalusC

@BalusC BalusC commented Nov 3, 2026

Copy link
Copy Markdown
Member

Identifiable no longer extends Serializable. BaseEntity declares Serializable again, so every entity base class in org.omnifaces.persistence.model stays serializable. IdentifiableTest asserts both.

This breaks only code which implements Identifiable directly and relies on inheriting Serializable from it.

Fixes #73

🤖 Generated with Claude Opus 5.5

@BalusC @claude
Do not require Identifiable to be Serializable
cc1409a 
Entities need not implement Identifiable since #36, so requiring
Serializable via Identifiable applied only to entities which opt in.
BaseEntity declares Serializable again, so its subclasses stay
serializable.

Fixes #73

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@BalusC
BalusC merged commit 5ee61d0 into develop Nov 3, 2026
3 checks passed
@BalusC
BalusC deleted the fix/73-identifiable-not-serializable branch November 3, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@BalusC