Repository navigation
Expose the ID of an entity via EntityRepository and BaseEntityService - #77
Merged
Merged
Conversation
EntityRepository#getId(E) returns the ID of an entity which need not implement Identifiable: via the persistence provider when it is a proxy, else via Identifiable#getId() when it implements it, else via its ID attribute. BaseEntityService#getId(E) is protected, like the other accessors which EntityRepository exposes publicly. Fixes #72 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EntityRepository#getId(E)returns the ID of an entity, also when the entity does not implementIdentifiable:Identifiable#getId()when the entity implements it;It returns
nullwhen the entity has no ID, e.g. when it has a generated ID and is not persisted yet.BaseEntityService#getId(E)isprotected, likegetIdentifierType()andisGeneratedId(), whichEntityRepositoryalso exposes publicly. A subclass ofBaseEntityServicewhich already has its own method namedgetIdwith another signature may now clash with it.No accessor for the name of the ID attribute is added: criteria and ordering on
"id"already resolve to the actual ID attribute.New ITs in
EntityRepositoryITcover an entity withoutBaseEntity(before and after persist, and a lazy reference, which is a proxy on Hibernate) and anIdentifiableentity. All tests pass on H2 with Hibernate, EclipseLink and OpenJPA.Fixes #72
🤖 Generated with Claude Opus 5.5