Repository navigation
Bump version to 2.0-SNAPSHOT and remove Identifiable - #79
Merged
Merged
Conversation
Since 1.2 the table name defaults to the entity name, AuditedChange reports the entity name, and several other behaviors changed, so the next release is a major version. Identifiable is therefore removed instead of deprecated: BaseEntity declares getId() and setId(I) itself, and Provider#getIdentifier accepts BaseEntity only. Use Page.ID instead of Identifiable.ID, and EntityRepository#getId(E) to get the ID of any entity. Also bump the test database H2 to 2.5.252. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…Identifier Provider#getIdentifier read the ID of a Hibernate proxy via LazyInitializer#getIdentifier(), which initializes the proxy under JPA proxy compliance. PersistenceUnitUtil#getIdentifier reads it without initializing the proxy. Provider#getIdentifier had no other use. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The next release is 2.0 instead of 1.3, because since 1.2 several behaviors changed: the table name defaults to the entity name instead of the class name,
AuditedChangereports the entity name,Identifiableis no longerSerializable, ordering on a@OneToManyor@ElementCollectionfield is correct across pages, and overriding the getters ofBaseEntityServiceno longer affects its internals.Being a major version,
Identifiableis removed instead of deprecated:BaseEntitydeclaresgetId()andsetId(I)itself, so its subclasses are not affected.Provider#getIdentifieris removed. The ID of a proxy is read viaPersistenceUnitUtil#getIdentifier, which, unlikeLazyInitializer#getIdentifier()under JPA proxy compliance, does not initialize the proxy.Page.IDinstead ofIdentifiable.ID,EntityRepository#getId(E)to get the ID of any entity, and extendBaseEntityor dropimplements Identifiableotherwise.OptimusFaces 1.x references
Identifiable, so it does not run on OmniPersistence 2.0. OptimusFaces 2.0 will.Also bumps the test database H2 to 2.5.252.
All tests pass on H2 with Hibernate, EclipseLink and OpenJPA.
Follow-up to #75
🤖 Generated with Claude Opus 5.5