Repository navigation
[Fix #1795] Refactoring test - #1800
Merged
Merged
Conversation
Signed-off by: Francisco Javier Tirado Sarti <ftirados@ibm.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused test refactor preserves the tested behavior and introduces no identified blocking issues.
No open issues 🎉
What changed in this PR
This test-only refactor simplifies the priority-selection regression tests associated with issue #1795 without changing production code or existing assertions.
Changes:
- Replaces the custom
ExpressionFactoryrecord with a Mockito-based helper. - Removes unused imports and boilerplate implementations while preserving all four priority-selection scenarios.
| File | Description |
|---|---|
impl/core/src/test/java/org/openworkflow/sdk/impl/CompositeExpressionFactoryTest.java |
Simplifies factory fixtures using Mockito while retaining regression assertions. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1795