Skip to content

Introduce more flexible storeChunk() syntax, use to add ADIOS2 memory selection - #1620

Open
franzpoeschel wants to merge 92 commits into
openPMD:devfrom
franzpoeschel:adios2-memory-selection
Open

franzpoeschel wants to merge 92 commits into
openPMD:devfrom
franzpoeschel:adios2-memory-selection

Conversation

@franzpoeschel

@franzpoeschel franzpoeschel commented May 17, 2024 •

Copy link
Copy Markdown
Contributor

We currently don't support memory selections yet, e.g. when you have a 2D memory buffer but want to write only an arbitrary block from it. That block is then non-contiguous, but ADIOS2 has so-called memory selections to support this.

We currently don't have an API that would be able to expose this (except in Python where the native Python buffer protocol is powerful enough to express this; we currently throw an error when detecting this strides in selection are inefficient, not implemented!). Since the loadChunk()/storeChunk() API is somewhat convoluted by now anyway, I didn't want to add even further overloads.

New API Design

The new API is centered around RecordComponent::prepareLoadStore(), which returns a configuration object that can be chained with various methods before executing the actual load/store operation.

Methods return an auxiliary::DeferredComputation<T> object that encapsulates the operation without immediately executing it. The computation is only performed when get() (or operator()()) is called on the returned object:

// Returns DeferredComputation<std::shared_ptr<int>>
auto result = E_y.prepareLoadStore()
    .offset({0, 5})
    .extent({1, 5})
    .load<int>();

// Execution happens here when get() is called
auto data = result.get();

Configuration Methods

The configuration chain supports:

  • offset(Offset) - Set the offset within the dataset (optional)
  • extent(Extent) - Set the extent within the dataset (optional)
  • memorySelection(MemorySelection) - Set memory selection for non-contiguous buffers (only available after withSharedPtr(), withRawPtr(), or withContiguousContainer())
  • unsafeNoAutomaticFlush(): The returned DeferredComputation object will be a no-op object. Buffers will still be returned, but they might not yet be written/read until manually flushing.

Buffer Specification Methods

If not specifying a buffer, the following allocating load/store operations are available:

  • storeSpan<T>() - Returns DynamicMemoryView<T> (a span-like view)
  • load<T>() - Returns DeferredComputation<std::shared_ptr<T>>
  • loadVariant() - Returns DeferredComputation<variant> for type-erased loading
  • load<T>(policy) - Returns std::shared_ptr<T>>

Alternatively, you may specify a buffer using one of:

  • withSharedPtr(std::shared_ptr<T>) - For shared pointer managed buffers
  • withUniquePtr(UniquePtrWithLambda<T>) - For unique pointer with custom deleter
  • withRawPtr(T*) - For raw pointer buffers
  • withContiguousContainer(Container&) - For contiguous containers (automatically deduces size if extent is not set)

The following operations are only available after specifying a buffer. Template parameters are no longer needed as the type is given through the buffer type:

  • store() / load() - Returns DeferredComputation<void>

(Load operations are only available after specifying a writable buffer, i.e. raw/shared pointer or contiguous container of non-const type)

ADIOS2 Memory Selection Support

This PR adds support for ADIOS2 memory selections, allowing writing from non-contiguous memory blocks:

std::shared_ptr<int> data;
E_y.prepareLoadStore()
    .offset({0, 5})
    .extent({1, 5})
    .withSharedPtr(data)
    .memorySelection({{1, 1}, {5, 5}})  // Write block from within the buffer
    .store();

Note: Memory selection support depends on ADIOS2 version. For ADIOS2 versions that cannot reset memory selections (PR ornladios/ADIOS2#4169), a warning is displayed. The API gracefully handles both cases.

Migration from Old API

The old loadChunk() and storeChunk() methods are now fully implemented using the new API internally, providing full backward compatibility while benefiting from the new implementation. Existing code continues to work without changes.

Examples of Old to New Migration

Old:

std::shared_ptr<int[]> data;
E_y.loadChunk(data, {0, 5}, {1, 5});

New:

auto result = E_y.prepareLoadStore()
    .offset({0, 5})
    .extent({1, 5})
    .withSharedPtr(data)
    .load<int>();
// Later: result.get();

Old:

std::vector<int> data(100);
E_y.storeChunk(data, {0, 5});

New:

E_y.prepareLoadStore()
    .offset({0, 5})
    .extent({1, 5})
    .withContiguousContainer(data)
    .store();

Design Considerations & Open Questions

Memory Selection Limitations

  • HDF5 backend throws an error when memory selection is specified (not supported by HDF5)
  • ADIOS2 requires version with memory selection reset support for clean reuse of variables
  • Memory selection only available after buffer specification (not on bare prepareLoadStore())

Files Changed

  • include/openPMD/LoadStoreChunk.hpp - New header with the main API
  • include/openPMD/LoadStoreChunk.tpp - Template implementations
  • include/openPMD/auxiliary/Future.hpp - New DeferredComputation wrapper
  • include/openPMD/Dataset.hpp - Added MemorySelection struct
  • include/openPMD/RecordComponent.hpp - Integration of new API
  • src/LoadStoreChunk.cpp - Non-template implementations
  • src/auxiliary/Future.cpp - DeferredComputation implementation
  • All IO backends (ADIOS2, HDF5, etc.) - Memory selection support

TODO

  • What about Python? The buffer protocol in Python may already support this; consider keeping Python API unchanged for now
  • Decide on deferred vs. immediate API style
  • Consider introducing .noop_future() option to disable future return types for cases where you don't need to track completion
  • Further binary size optimization

Related

TODO:

  • look at hpx future for inspiration

@franzpoeschel
franzpoeschel force-pushed the adios2-memory-selection branch 2 times, most recently from 727cbbc to ddcdfc9 Compare May 22, 2024 11:44
@ax3l
ax3l self-requested a review May 31, 2024 17:50
@ax3l ax3l self-assigned this May 31, 2024
@franzpoeschel
franzpoeschel force-pushed the adios2-memory-selection branch from c05d535 to ba7c582 Compare June 7, 2024 12:41
@franzpoeschel
franzpoeschel force-pushed the adios2-memory-selection branch from ba7c582 to d7eb891 Compare June 24, 2024 12:47
Comment thread src/LoadStoreChunk.cpp Fixed
Comment thread src/LoadStoreChunk.cpp Fixed
@franzpoeschel
franzpoeschel force-pushed the adios2-memory-selection branch 2 times, most recently from 332932f to efb0876 Compare June 25, 2024 13:56
Comment thread src/LoadStoreChunk.cpp Fixed
@franzpoeschel
franzpoeschel force-pushed the adios2-memory-selection branch from efb0876 to 39e3d71 Compare June 26, 2024 11:48
@franzpoeschel
franzpoeschel force-pushed the adios2-memory-selection branch 4 times, most recently from 47d497b to b2bc355 Compare July 22, 2024 10:21
@franzpoeschel
franzpoeschel force-pushed the adios2-memory-selection branch from b699520 to 3430b6d Compare July 23, 2024 14:05
@franzpoeschel
franzpoeschel force-pushed the adios2-memory-selection branch from 9b5acff to bd7b378 Compare September 3, 2024 13:06
@franzpoeschel
franzpoeschel force-pushed the adios2-memory-selection branch from 208c381 to e51e635 Compare November 15, 2024 14:45
@franzpoeschel
franzpoeschel force-pushed the adios2-memory-selection branch 2 times, most recently from c8be94b to 8e455b4 Compare December 17, 2024 11:09
@franzpoeschel
franzpoeschel force-pushed the adios2-memory-selection branch from 8e455b4 to 430fe3b Compare February 21, 2025 12:06
@franzpoeschel
franzpoeschel force-pushed the adios2-memory-selection branch from 430fe3b to e98c840 Compare March 26, 2025 14:33
@franzpoeschel
franzpoeschel force-pushed the adios2-memory-selection branch 2 times, most recently from 190674f to e04f76d Compare April 4, 2025 08:32
@franzpoeschel
franzpoeschel force-pushed the adios2-memory-selection branch from b99bb95 to d05e029 Compare April 22, 2025 09:09
Blablador and others added 17 commits October 21, 2026 11:48
Split the joined-dimension buffer-API regression test out of
SerialIOTest.cpp into test/Files_SerialIO/joined_dim_buffer_api.cpp and
register it in CMakeLists.txt, matching the convention of the other
per-issue SerialIO test files.
A joined dimension's extent is only known once all writers have flushed and
the data is read back (close + reopen). During the write session the extent
is Dataset::JOINED_DIMENSION (max), so loading a chunk of a joined array is
not a meaningful operation: the total size is unknown and the streaming
engine cannot read the data back mid-write. After a reopen the extent is
concrete, joinedDimension() is nullopt, and the load goes through the normal
non-joined path (the case exercised by the joined_dim test).

The previous change made loadChunk_impl mirror the store path by accepting an
empty offset for joined arrays, which only validated the in-session case and
then queued a READ_DATASET for 2^64 elements. Reject joined arrays in
loadChunk_impl with a clear error instead; the store path (append) is
unchanged.

Update the joined_dim_buffer_api regression test: store with an empty {} and
a {0} offset still passes the frontend checks, while every buffer-based load
overload now throws error::WrongAPIUsage.
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
Rejecting a memory selection inside the backend's writeDataset() throws
while an IO task is being flushed. AbstractIOHandlerImpl::flush() reacts to
an exception in an IO task by clearing the whole IO queue and rethrowing
("Clearing IO queue and passing on the exception"), so every other pending
chunk and the file's root attributes are dropped. The subsequent flush()
and close() then report success, but the file can no longer be read back
(AttributeNotFound: openPMD) in HDF5 and JSON.

Whether a backend supports non-contiguous memory selections is known when
the chunk is enqueued, so check it in RecordComponent::storeChunk_impl()
and throw error::OperationUnsupportedInBackend there, before anything is
queued. Add AbstractIOHandler::supportsMemorySelection(), defaulting to
false and overridden to true only in ADIOS2IOHandler. The backend-side
throws stay as a safety net.

Add a regression test that stores a valid chunk, attempts a rejected
memory selection on another component, and verifies that the Series stays
usable and that the valid chunk and a root attribute survive the roundtrip
in HDF5 and JSON. Without the early check the test fails at flush time.
A memory selection could not be reset before ADIOS2 v2.10.1 (the reset
capability was added upstream in v2.11.0 and backported to 2.10.1). On
older versions a stale memory selection silently leaked into every
following store operation of the same variable, producing wrong data or
out-of-bounds reads. This affected later storeChunk() calls, later steps
and the unique_ptr path.

Instead of applying a workaround, report ADIOS2 as not supporting memory
selections in that case via AbstractIOHandler::supportsMemorySelection(),
so the frontend rejects them up front, and keep the backend-side check in
verifyDataset() as a safety net. Both reuse the existing
CanTheMemorySelectionBeReset trait. Remove the now-obsolete one-time
warning and its bookkeeping.

Adapt available_chunks_test and memory_selection_rejected_before_flush to
use an equivalent contiguous buffer / expectation where memory selections
are unsupported, and add a dedicated memory_selection_old_adios2 test.
Pin the ADIOS2 v2.10 CI job to 2.10.0 to exercise the rejection path.
store() moves the buffer out of the (copyable, shared) configuration, and
load() reads from it, but nothing prevented a second use of the same
configuration or of a copy sharing the buffer. A second store() then
enqueued an empty WriteBuffer and crashed when the backend dereferenced
the moved-from std::any.

Track consumption in a flag shared between copies of the configuration
and report reuse as error::WrongAPIUsage.
DeferredComputation's move-assignment was defaulted, so assigning over a
handle that still held a valid task silently overwrote (and dropped) that
task. For the handles returned by store()/load() this means a data
operation, and possibly a collective flush, would never run and no error
would be reported.

Execute the target's pending task before overwriting it, mirroring the
destructor behavior. Add a regression test.
The legacy storeChunk() / loadChunk() overloads expand an offset of {0}
and an extent of {-1u} to the dataset dimensionality, i.e. they mean
"default / full selection". The chaining API took these values
literally, so migrating storeChunk(data, {0}, {-1u}) to
.offset({0}).extent({-1u}) changed the meaning and could fail with a
dimensionality error on multi-dimensional datasets.

Reset the stored offset/extent when the sentinel is passed, restoring the
legacy behavior, and document it on offset()/extent(). Add a regression
test.
Merge the two memory-selection tests into a single memory_selection.cpp
and the two DeferredComputation tests into one future_test with sections.
Rename container_buffer_size_1d_downsizes.cpp to container_buffer_size.cpp
since it covers more than the 1-D downsize case.
@franzpoeschel
franzpoeschel force-pushed the adios2-memory-selection branch from 1f77b1e to 3169a99 Compare October 21, 2026 09:49
franzpoeschel and others added 7 commits October 21, 2026 15:49
- Document buffer lifetime and enqueue timing for the deferred
  load/store API, and align destructor/flush documentation with the
  no-execute-on-destruction behavior.
- Reject joined-dimension loads before allocating a buffer of
  JOINED_DIMENSION elements.
- Do not throw from the UniquePtrWithLambda deleter: deleting a
  unique_ptr is noexcept. Warn and skip deletion on disassociation.
@franzpoeschel
franzpoeschel force-pushed the adios2-memory-selection branch from 02aed2c to e24785b Compare October 27, 2026 14:44

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants