Repository navigation
feat(classification): support canonical records with host reviews - #1662
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
zcrab-oai
left a comment
There was a problem hiding this comment.
Reviewed d3390ba with Codex, including an independent verification pass. No actionable findings in the immutable input bindings, host review contract, cancellation/error handling, or preservation of saved-scan and deduplication behavior.
All 40 focused classification and CLI tests passed locally, and all required CI checks pass. Broader local verification was limited by missing native build artifacts in the fresh checkout.
This approval covers the current commit. The merge conflicts with main still need resolution, followed by checks of the resolved changes.
Summary
Add repository-free severity classification for canonical reports. A host can submit an immutable Markdown rubric and report snapshots, execute the requested model reviews, and receive computed assessments without changing original severity or requiring a saved scan.
Changes
classify-severity --recordsand the typedclassifySeverityRecords()SDK entrypoint using version 1 JSON-RPC.Testing
Current merge head:
f9f3438f, incorporating mainbb65abd1.bb65abd1(policy output-directory permissions and multiscan recovery/permissions). This is incomplete local coverage, not a full-suite pass; the random full-suite rerun was not completed.Risk and rollout
The new mode is opt-in and uses host-provided execution; it does not create model sessions, credentials, or repository checkouts. Hosts must authorize the requested model, cancel remote work, and compare immutable bindings before conditionally persisting computed fields. No existing published package is claimed to contain this capability: require an artifact containing this change and verify protocol version 1 before use. No release or runtime activation is included.
Public disclosure review