Skip to content

feat(classification): support canonical records with host reviews - #1662

Merged
kmbroai merged 5 commits into
mainfrom
feat/classify-severity-records
Oct 19, 2026
Merged

kmbroai merged 5 commits into
mainfrom
feat/classify-severity-records

Conversation

@kmbroai

@kmbroai kmbroai commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Add repository-free severity classification for canonical reports. A host can submit an immutable Markdown rubric and report snapshots, execute the requested model reviews, and receive computed assessments without changing original severity or requiring a saved scan.

Changes

  • Add classify-severity --records and the typed classifySeverityRecords() SDK entrypoint using version 1 JSON-RPC.
  • Verify exact UTF-8 SHA-256 hashes and echo record/rubric revisions; preserve report JSON verbatim in model prompts and reject mismatched assessments.
  • Reuse the existing records transport, preserve saved-scan behavior, and return explicit unresolved results after review failures. Document host execution, cancellation, capability probing, and conditional persistence.
  • Include the new compiled modules and guide in the strict package allowlist.

Testing

Current merge head: f9f3438f, incorporating main bb65abd1.

  • 178 focused tests passed across classification records, deduplication records, validation records, hosted scans, Node host protocol, and package archive fixtures.
  • SDK type checking, full formatting, bundled plugin build, SDK build, and npm archive creation passed.
  • Three independent native reviews of the full branch diff and a distinct verification pass found no actionable issues on this exact head.
  • The broad seeded local SDK run was interrupted after 2,078 observed passes and 15 failures. All 15 failing cases reproduce on unchanged main at bb65abd1 (policy output-directory permissions and multiscan recovery/permissions). This is incomplete local coverage, not a full-suite pass; the random full-suite rerun was not completed.
  • Installed-package smoke passed native lifecycle contracts, hosted SDK/CLI checks, compatibility and nested-worker checks, then failed in the final Deep Scan fixture with an output-parent permission check and a worker-interruption assertion. These match the two failures previously reproduced on the unchanged base. The full installed smoke did not pass; no permission or timeout workaround was used.
  • Earlier records-specific installed-package validation passed on the pre-merge head; it is inherited evidence, not a rerun on this head. Fresh remote CI is pending.

Risk and rollout

The new mode is opt-in and uses host-provided execution; it does not create model sessions, credentials, or repository checkouts. Hosts must authorize the requested model, cancel remote work, and compare immutable bindings before conditionally persisting computed fields. No existing published package is claimed to contain this capability: require an artifact containing this change and verify protocol version 1 before use. No release or runtime activation is included.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the enhancement New feature or request label Oct 16, 2026
@kmbroai
kmbroai marked this pull request as ready for review October 16, 2026 21:36
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-10-16T23:04:11.108774Z f9f3438 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@zcrab-oai zcrab-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed d3390ba with Codex, including an independent verification pass. No actionable findings in the immutable input bindings, host review contract, cancellation/error handling, or preservation of saved-scan and deduplication behavior.

All 40 focused classification and CLI tests passed locally, and all required CI checks pass. Broader local verification was limited by missing native build artifacts in the fresh checkout.

This approval covers the current commit. The merge conflicts with main still need resolution, followed by checks of the resolved changes.

@kmbroai
kmbroai merged commit 67a8df8 into main Oct 19, 2026
124 of 156 checks passed
@kmbroai
kmbroai deleted the feat/classify-severity-records branch October 19, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants