Repository navigation
feat: import Endor Labs findings - #1689
Draft
mldangelo-oai wants to merge 10 commits into
Draft
mldangelo-oai wants to merge 10 commits into
mldangelo-oai wants to merge 10 commits into
Conversation
3 tasks done
# Conflicts: # sdk/typescript/src/external-findings-publish.ts # sdk/typescript/tests-ts/external-findings-publish.test.ts
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
--provider endorfor native Endor Finding JSON and self-contained endorctl SARIF 2.1.0. Both formats retain finding UUIDs and original source evidence through the existing preview, confirmation, checkpoint, and readback flow. Stacked on #1687.Changes
Maps native SAST and AI SAST paths and primary start lines, preserves reported SARIF lines for code and secret categories, and decodes URI escapes before validating repository paths. Indexed, base-relative, unsafe, or malformed artifact locations remain in the original evidence without an asserted repository path.
For new uploads, declared SARIF repository URLs must match the selected Cloud repository. Saved requests keep their original repository ID and can resume after a repository rename.
Rejects unfinished paginated JSON responses, ambiguous identities, invalid records, and external SARIF property files. Fractional timestamps survive in source evidence while Cloud timestamps use epoch seconds. Missing severity or revision stays unknown; source verdicts remain separate from Codex assessments.
Testing
Hosted CI must qualify this updated head. Live Cloud upload and readback remain separate requirements.
Risk and rollout
Requires compatible Cloud import support. Preserve a stable source key across exports and inspect exclusions before publishing. This does not run validation scans, fetch report URLs, or enable deployment gates.
Public disclosure review