Repository navigation
Measure subtitle pauses from the end of the preceding word - #2899
Open
justavibedev wants to merge 1 commit into
Open
justavibedev wants to merge 1 commit into
justavibedev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When word timestamps,
max_line_width, andmax_line_countare enabled, the subtitle writer starts a new cue after a long pause. It currently subtracts the start times of consecutive words. A word from 0–1s followed by a word starting at 3.5s therefore triggers a break, even though the gap is only 2.5s and both words fit on one line.Use the previous word's end to measure the gap. The existing threshold remains strictly greater than three seconds. This only changes how the SRT/VTT writers group already-timed words; it does not change the transcript or its timestamps.
#1184 describes the onset-based calculation as a workaround for stretched boundary words and points to the now-merged timing heuristic in #1114. The tradeoff is that if a predicted word end still extends into silence, the writer will use that end rather than infer an earlier pause.
I tested gaps below, at, and above the threshold. Two cases fail on main (
8609812), and the genuine long-pause control passes. With the patch, all three pass; the selected writer, tokenizer, and normalizer tests total 11 passes. These are offline tests with synthetic timings, not an evaluation of alignment quality on real audio.Developed and tested with Codex assistance.