Repository navigation
Conversation
| // All-day / Specific-time toggle — shown BEFORE the date/time row | ||
| String allDayFieldName = context.getFieldName(allDayWidget); | ||
| sb.append("<p class=\"schedule-appointment-timing\">"); | ||
| sb.append("<label>").append(msg("htmlformentry.scheduleAppointment.timing")) |
There was a problem hiding this comment.
With the toggle gone, the htmlformentry.scheduleAppointment.timing and htmlformentry.scheduleAppointment.specificTime keys aren't referenced from anywhere anymore, but they're still in messages.properties and the es/fr/ht bundles. Worth dropping them in this PR so the dead strings don't stick around in the translation files. (allDay is still used by the view-mode rendering, so that one stays.)
| msg("htmlformentry.scheduleAppointment.error.timeRequired"))); | ||
| } | ||
| Date time = (Date) startDateTimeWidget.getTimeWidget().getValue(context, submission); | ||
| if (time == null) { |
There was a problem hiding this comment.
Could we add a validation test that omits the time selects (and one omitting duration), along the lines of shouldRequireServiceInlineNotAsGlobalError? Making time and duration unconditionally required is the one behavior this PR changes, and every submission test in the suite supplies both, so nothing would fail if the requirement quietly regressed. Not a blocker.
|
Added a couple tests on the time and duration fields, and removed the unused translation strings. |
"All-day Appointment" is not well-supported by the appointments module, despite that being an option in the O3 appointments app (via config). This PR removes the ability to schedule all-day appointments in the
<scheduleAppointments>element, since we don't need it anyway.