[mseaton]

Summary

• <lookup> (or other substitution) tags nested inside inline <script> blocks get whitespace/newlines injected around the substituted value when the form also contains <macros>, <page>, <translations>, or <subform>.
• Root cause: those elements each trigger an internal String→DOM→String round-trip in HtmlFormEntryGenerator (via HtmlFormEntryUtil.documentToString()) before the <lookup> tag is actually substituted by applyTags(). documentToString() sets OutputKeys.INDENT="yes", and JAXP's indenting transformer inserts whitespace text nodes around element boundaries in mixed text/element content — corrupting a <lookup> sitting inside <script> text. A literal newline injected into a quoted JS string is invalid syntax, so the browser throws Uncaught SyntaxError: Invalid or unexpected token and the script fails to run.
• Fix: add a documentToString(Document, boolean indent) overload, and pass indent=false at the 4 purely-internal round-trip call sites (applyMacros, processPages, applyTranslations, processSubforms) since that intermediate xml is only consumed by further string/regex processing, never shown to a human. InitializerExportUtil and OrderTagAttributeDescriptor keep indent=true, preserving human-readable exported form XML.

Test plan

• mvn -pl api compile succeeds
• mvn -pl api test passes (no regressions)
• Manually verify against the original repro form (an ART Visit-style htmlform with <macros> and a <script> block containing <lookup expression="patient.uuid"/>) that the rendered script is no longer corrupted

🤖 Generated with Claude Code