Repository navigation
pts: variant index in polars #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
d0choa
wants to merge
7
commits into
main
Choose a base branch
from
feat/pts-variant-polars
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
92f0f1b
pts: variant index in polars (POC)
d0choa 5d0eaad
pts: variant annotation parts tolerate column drift between parts
d0choa fd347ea
pts: variant step lists parts through a shared helper and skips FoldX…
d0choa f2ccc4b
pts: variant step becomes the transformers/variant package
d0choa 348054a
pts: variant score normalisation rescales with the shared min_max_scaler
d0choa c6168f6
pts, orchestration: FoldX annotations run inside the variant step
d0choa 75d5f93
pts: one variant identifier hashing rule for evidence, LoF curation a…
d0choa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,17 @@ | ||
| """The PySpark variant index runs on its own Dataproc cluster, after FoldX on a VM.""" | ||
| """The variant index runs on a VM, after FoldX.""" | ||
|
|
||
| from orchestration.dags.config.unified_pipeline import UnifiedPipelineConfig | ||
| from orchestration.models.pts_step import PTSDataprocStep, pts_step_from_config | ||
| from orchestration.models.pts_step import pts_step_from_config | ||
|
|
||
|
|
||
| def test_variant_runs_on_its_dataproc_cluster() -> None: | ||
| def test_variant_and_foldx_run_on_vms() -> None: | ||
| config = UnifiedPipelineConfig() | ||
| step = pts_step_from_config('pts_variant', config) | ||
| assert isinstance(step, PTSDataprocStep) | ||
| assert step.cluster_definition.cluster_type == 'pts_variant' | ||
| assert pts_step_from_config('pts_variant', config).is_gce | ||
| assert pts_step_from_config('pts_foldx', config).is_gce | ||
|
|
||
|
|
||
| def test_foldx_runs_on_a_vm_before_the_variant_index() -> None: | ||
| def test_foldx_runs_before_the_variant_index() -> None: | ||
| config = UnifiedPipelineConfig() | ||
| assert pts_step_from_config('pts_foldx', config).is_gce | ||
| assert config.step_definition('pts_foldx')['depends_on'] == ['pis_variant'] | ||
| # pis_variant is reached through pts_foldx, so the index does not list it again. | ||
| assert config.step_definition('pts_variant')['depends_on'] == ['pts_foldx', 'gentropy_variant_annotation'] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that the step is run on a single machine, I would get rid of foldx step and embed it here. No need to spawn machine two times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, done in c6168f6. FoldX is now the first task of the
variantstep, andpts_foldxis removed from the DAG. Only the variant index reads its output.