Repository navigation
orchestration, pis: move the gwas catalog sumstats pics release into a dated prod run folder - #226
Merged
Conversation
…a dated prod run folder The 2026-08-28 summary statistics PICS run now lives in gs://gwas_catalog_sumstats_pics/prod/20260828T115527/ with its outputs under output/, its DAG config under config/ and its docs under docs/. - gwas_catalog_sumstats_pics.yaml: output_path points at the run's output/ folder - pis/config.yaml: GCSS PICS study index and credible sets read from the run folder - docs: split the sumstats PICS docs into gwas_catalog_sumstats_pics/README.md, with the inputs, gentropy links pinned to v3.4.0-rc.3 and the output schemas; regenerate the DAG svg - Makefile: upload-gwas-catalog-sumstats-pics-readme uploads only the sumstats PICS docs to a run folder given by BUCKET; the GWAS Catalog upload no longer copies the full docs to the sumstats PICS bucket Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5 tasks
addramir
reviewed
Oct 29, 2026
addramir
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Merges clean on current main and matches the #220 pattern.
upload-gwas-catalog-sumstats-pics-readme(and the top hits one) is missing from.PHONY.upload-gwas-catalog-buckets-readmestill copies the newgwas_catalog_sumstats_pics/subfolder togs://gwas_catalog_inputs/docsandgs://gwas_catalog_sumstats_susie/docs. Fine for now; worth a follow-up.../README.md#gwas-catalog-inputswill not resolve in the copy under$(BUCKET)/docs.
addramir
approved these changes
Oct 29, 2026
This was referenced Oct 30, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 2026-08-28 GWAS Catalog summary statistics PICS run was moved from the root of
gs://gwas_catalog_sumstats_picsinto a dated run folder, so the release is preserved before the DAG runs on gentropy v4.0.0 with the new credible set schema. As for the top hits (#220), this allows comparing the results and rolling back.The timestamp is the time of the first object written by the run (the study index, 2026-08-28T11:55:27Z).
This PR points the repo at the new location:
gwas_catalog_sumstats_pics.yaml:output_pathis nowgs://gwas_catalog_sumstats_pics/prod/20260828T115527/output. It is identical to the config uploaded to the run folder; the rest of the config (sync_date: '20260802',GENTROPY_REF: v3.4.0-rc.3) is the one of the run.pis/config.yaml: the GCSS PICS study index and credible sets are copied from the run'soutput/. The data is the same v3 release:pismoves to the v4 outputs once the credible set validation readsCredibleSetandCredibleSetVariant.docs/datasources/gwas_catalog_data/gwas_catalog_sumstats_pics/README.md. The new README:v3.4.0-rc.3upload-gwas-catalog-sumstats-pics-readmeuploads only the sumstats PICS docs to$(BUCKET)/docs, and fails whenBUCKETis not set (make upload-gwas-catalog-sumstats-pics-readme BUCKET=gs://gwas_catalog_sumstats_pics/prod/20260828T115527). It is not part ofupdate-bucket-docs. The GWAS Catalog upload no longer copies the full docs to the sumstats PICS bucket.The bucket is already in this state. The data was copied, and the config and docs were uploaded; the files in this PR are identical to the uploaded copies.
After merge
pisonmainuntil this is merged:study_index/,study_locus_window_based_clumped/,study_locus_ld_clumped/,credible_sets/anddocs/.Notes
output_pathpinned to the run folder, running the old DAG again would overwrite this release. The next run moves the DAG toStagingDagConfigon gentropy v4 with its own run folder.Test plan
uv run pytest tests/test_dag_validation.py(orchestration): 10 passeduv run pytest tests(pis): 10 passedmake -n upload-gwas-catalog-sumstats-pics-readmefails withoutBUCKETand resolves to the run folder with itgs://gwas_catalog_sumstats_pics/prod/20260828T115527/study_index/*.parquet(1 file) andcredible_sets/*.parquet(23 files) globs inpis/config.yamlmatch files in the run folder🤖 Generated with Claude Code