Repository navigation
Highlight same-value cells in the focused column - #33
Merged
Merged
Conversation
Focus a result-grid cell to highlight other cells in that column with the same value. Empty and NULL are ignored. The choice persists with the other table interaction prefs. Co-authored-by: Pavitra Golchha <hello@pavi2410.com>
cursor
Bot
force-pushed
the
cursor/same-value-highlight-f175
branch
from
October 3, 2026 20:34
925d7ac to
6392068
Compare
Fill the table cell bounds with #57524f at 1/3 opacity so zebra rows still show through, instead of a full-strength chip around the text. Selection ring stays on top. Co-authored-by: Pavitra Golchha <hello@pavi2410.com>
render_td was shrink-wrapping to cell_chrome, so both the wash and gpui-kit's absolute selection ring followed the glyph box. Use the same in-flow flex_1/min_w_0/size_full fill as column headers. Co-authored-by: Pavitra Golchha <hello@pavi2410.com>
Pin every td to the kit cell with absolute inset_0 so the wash covers the cell, restore table_cell_size on an inner box so labels keep their inset, and wash the focused cell too. The kit selection ring stays on top. Co-authored-by: Pavitra Golchha <hello@pavi2410.com>
Co-authored-by: Pavitra Golchha <hello@pavi2410.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26.
What
Selecting a cell in a result grid washes other cells in that same column with the same value, including the focused cell. Settings → Query defaults → Table interaction has a Highlight same values switch. It is stored in
native_preferences.tomlwith the other table prefs.Look
The wash covers the full cell bounds (not a text chip, not an inset). Color is warm gray
#57524fat 1/3 opacity over the row background so zebra striping still shows. The focused cell gets the same wash; the blue selection ring is drawn on top.Every
render_tdis pinned to the kit cell withabsolute().inset_0()so the wash uses the cell box, not the glyph box. Kittable_cell_sizepadding is restored on an inner box, so matching labels keep the same left inset as unmatched labels.Behavior
NULLnever match.Default is on, same as the other table-interaction switches.