Repository navigation
Use gpui-kit HoverCard for datetime cell hovers - #35
Merged
Merged
Conversation
The cell is the trigger and Anchor::TopLeft lets the kit place the card just under the cell and flip it. Drop the custom Positioner. Co-authored-by: Pavitra Golchha <hello@pavi2410.com>
The helper's impl IntoElement captured the content Fn's rows/cx lifetimes and failed to compile. Co-authored-by: Pavitra Golchha <hello@pavi2410.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #34. Datetime grid cells now use gpui-kit
HoverCardinstead of a customPositionercard.HoverCard::new+.trigger(cell)+.anchor(Anchor::TopLeft)so the popup hangs just under the cell and the kit can flip it.timestamptz/timestamp with time zoneremapped toINTEGERwhen the cell text is a parseable instant. Real integers stay numeric.Popover stays click-to-open and Tooltip stays a hint; HoverCard is the hover overlay that fits this.
Draft only — please do not mark ready or merge from this PR.