Repository navigation
fpm: Use recommended order for OpenMetrics stat metadata - #23871
Merged
Merged
Conversation
TimWolla
requested changes
Sep 24, 2026
TimWolla
left a comment
TimWolla
left a comment
Member
There was a problem hiding this comment.
Looking at https://prometheus.io/docs/specs/om/open_metrics_spec/#metricfamily-metadata:
The ordering SHOULD be TYPE, UNIT, HELP.
The order for phpfpm_listen_queue_length is the expected order and all the others are wrong.
And given this is a SHOULD, it is a master-only fix. I misunderstood that as part of the other PR.
1ma
changed the title
1ma
force-pushed
the
fix-openmetrics-nit
branch
from
September 24, 2026 10:08
c349652 to
6a32172
Compare
Contributor
Author
|
My bad, I should have checked the authoritative source like you did. Order fixed and target branch switched to master. |
TimWolla
approved these changes
Sep 25, 2026
TimWolla
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #23808. I was asked by @TimWolla on Discord to submit this bit separately.