Repository navigation
Conversation
TimWolla
reviewed
Oct 29, 2026
| --SKIPIF-- | ||
| <?php | ||
| if (!extension_loaded("openssl")) | ||
| die("skip mysqlnd is built without SSL support, so the sha256_password plugin is not available"); |
Member
There was a problem hiding this comment.
In this case the skip message provides additional detail. Should we support comment lines in the EXTENSIONS section?
Member
There was a problem hiding this comment.
No, that detail is not important. We already have --TEST-- section which mentions which plugin it uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests still don't use
--EXTENSIONS--for extension checks.