Skip to content

Keep candidate ID when copying - #1044

Merged
fippo merged 1 commit into
mainfrom
candidate-copy-id
Oct 16, 2026
Merged

fippo merged 1 commit into
mainfrom
candidate-copy-id

Conversation

@fippo

@fippo fippo commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

GetSelectedCandidatePair returns copies of the selected candidates. These were created by unmarshaling and got new random IDs, so they no longer matched the IDs in candidate and candidate pair stats.

GetSelectedCandidatePair returns copies of the selected candidates.
These were created by unmarshaling and got new random IDs, so they
no longer matched the IDs in candidate and candidate pair stats.
@fippo

fippo commented Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

(I don't think anyone compares these but... pion/webrtc#3633)

@codecov

codecov Bot commented Oct 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.62%. Comparing base (be2e97c) to head (09580cd).

Files with missing lines Patch % Lines
candidate_base.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1044      +/-   ##
==========================================
- Coverage   91.69%   91.62%   -0.07%     
==========================================
  Files          45       45              
  Lines        5453     5456       +3     
==========================================
- Hits         5000     4999       -1     
- Misses        453      457       +4     
Flag Coverage Δ
go 91.62% <87.50%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fippo
fippo merged commit 5fdc5b1 into main Oct 16, 2026
20 checks passed
@fippo
fippo deleted the candidate-copy-id branch October 16, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants