Repository navigation
Conversation
Add PacketsSent and PacketsReceived next to the byte counters so transport stats can report packet counts. Like the byte counters they do not include ICE connectivity checks.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1046 +/- ##
==========================================
- Coverage 91.66% 91.64% -0.02%
==========================================
Files 45 45
Lines 5456 5461 +5
==========================================
+ Hits 5001 5005 +4
- Misses 455 456 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| bytesSent atomic.Uint64 | ||
| packetsReceived atomic.Uint64 | ||
| packetsSent atomic.Uint64 | ||
| agent *Agent |
There was a problem hiding this comment.
it feels like agent should come first here?
There was a problem hiding this comment.
I'll add a lint rule for this soon, also fieldalignment (wouldn't matter here since both orders are the same on 64), but i need to make the lint able to do --fix in the CI first
JoTurk
left a comment
JoTurk
left a comment
There was a problem hiding this comment.
It would have been nice if we could export a single stats object but i think this is fine and the overhead for a struct is probably a bad idea
Add PacketsSent and PacketsReceived next to the byte counters so transport stats can report packet counts. Like the byte counters they do not include ICE connectivity checks.