Repository navigation
Conversation
actyp
left a comment
There was a problem hiding this comment.
The changes are OK. Just for the sake of versioning, should we bump the edhoc-fuzzer version to 2.0.0 or something different?
|
Bumping the major version (is supposed to) means that some important functionality and/or breaking changes (in the API) were made, and neither of these is the case in this PR. It just allows EDHOC-Fuzzer to be set up without having to use a custom install of PSF. However, it's OK to bump some minor version (e.g. 1.1.0, or similar) if you feel this is good to do. |
|
I agree with both statements, but the change of |
|
I think we seem to be having different views of what version numbers mean and how they should be used. For a code base like EDHOC-Fuzzer, which does not even have a single release yet (neither on Maven nor on GitHub), and which is not a library that is supposed to be used in some other code base, I would argue that version numbers are irrelevant/uninteresting. But it's possible that I am missing something. If we decide (that we need/want) to use version numbers more properly, perhaps we should discuss the issue of making a release - and what functionality this release should contain. IMO, it seems a bit weird that the first release of a tool is tagged 2.x.y, but I am willing to hear the counterarguments. |
|
I understand. There is no real need currently to use version numbers in EDHOC-Fuzzer, so we can merge this as is. Can you rebase on top of main first to see if there are any issues? |
|
I am sure there are no issues. Merging. |
Adjust the code base to use ProtocolState-Fuzzer from Maven (currently 0.3.0, which is the most recent version), and stop explicitly building PSF during fuzzer setup.
The PR required adjustment to many files because the imports need to reference
io.github....instead ofcom.github..... For uniformity, EDHOC-Fuzzer's code base was moved underio/gihub/...instead ofcom/github/....Supersedes #161