Skip to content

Adjust code base to use PSF 0.3.0 from Maven - #162

Merged
kostis merged 2 commits into
mainfrom
mvn-psf
Oct 16, 2026
Merged

kostis merged 2 commits into
mainfrom
mvn-psf

Conversation

@kostis

@kostis kostis commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Adjust the code base to use ProtocolState-Fuzzer from Maven (currently 0.3.0, which is the most recent version), and stop explicitly building PSF during fuzzer setup.

The PR required adjustment to many files because the imports need to reference io.github.... instead of com.github..... For uniformity, EDHOC-Fuzzer's code base was moved under io/gihub/... instead of com/github/....

Supersedes #161

@kostis
kostis requested a review from actyp October 15, 2026 10:47

@actyp actyp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are OK. Just for the sake of versioning, should we bump the edhoc-fuzzer version to 2.0.0 or something different?

@kostis

kostis commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

Bumping the major version (is supposed to) means that some important functionality and/or breaking changes (in the API) were made, and neither of these is the case in this PR. It just allows EDHOC-Fuzzer to be set up without having to use a custom install of PSF. However, it's OK to bump some minor version (e.g. 1.1.0, or similar) if you feel this is good to do.

@actyp

actyp commented Oct 16, 2026

Copy link
Copy Markdown
Member

I agree with both statements, but the change of groupid (for the edhoc-fuzzer) and the file paths in general is a major (breaking) change technically speaking. I would suggest to use 2.0.0 to signal (to us) that is the new version using the proper io.github.protocol-fuzzing.edhoc-fuzzer identifier.

@kostis

kostis commented Oct 16, 2026

Copy link
Copy Markdown
Member Author

I think we seem to be having different views of what version numbers mean and how they should be used. For a code base like EDHOC-Fuzzer, which does not even have a single release yet (neither on Maven nor on GitHub), and which is not a library that is supposed to be used in some other code base, I would argue that version numbers are irrelevant/uninteresting. But it's possible that I am missing something.

If we decide (that we need/want) to use version numbers more properly, perhaps we should discuss the issue of making a release - and what functionality this release should contain. IMO, it seems a bit weird that the first release of a tool is tagged 2.x.y, but I am willing to hear the counterarguments.

@actyp

actyp commented Oct 16, 2026

Copy link
Copy Markdown
Member

I understand. There is no real need currently to use version numbers in EDHOC-Fuzzer, so we can merge this as is.

Can you rebase on top of main first to see if there are any issues?

@kostis

kostis commented Oct 16, 2026

Copy link
Copy Markdown
Member Author

I am sure there are no issues. Merging.

@kostis
kostis merged commit 5c10847 into main Oct 16, 2026
23 of 24 checks passed
@kostis
kostis deleted the mvn-psf branch October 16, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants