Repository navigation
Eliminate Arena::{Copy,Default}Construct<T> per-type instantiations in protoc. - #30766
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_1000887905
branch
from
October 16, 2026 23:46
b3130ff to
ae3aad3
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_1000887905
branch
3 times, most recently
from
October 22, 2026 01:02
fcc7d14 to
4e7e360
Compare
…n protoc. Every generated message type currently gets two out-of-line functions that exist only to give copy and default construction a uniform signature: `Arena::CopyConstruct<T>` and `Arena::DefaultConstruct<T>` (explicitly instantiated in the .pb.cc, `extern template` in the .pb.h). They are trampolines: allocate `sizeof(T)` and call the constructor. PiperOrigin-RevId: 1000887905
copybara-service
Bot
force-pushed
the
test_1000887905
branch
from
October 22, 2026 02:12
4e7e360 to
fc6c854
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminate Arena::{Copy,Default}Construct per-type instantiations in protoc.
Every generated message type currently gets two out-of-line functions that
exist only to give copy and default construction a uniform signature:
Arena::CopyConstruct<T>andArena::DefaultConstruct<T>(explicitlyinstantiated in the .pb.cc,
extern templatein the .pb.h). They aretrampolines: allocate
sizeof(T)and call the constructor.