Repository navigation
TUI and Mac app: passphrases for encrypted volumes - #32
Merged
Merged
Conversation
Making a volume from a folder takes an optional passphrase (twice) and encrypts it; adding a volume takes one for encrypted volumes. The passphrase reaches rustfuse in RUSTFUSE_PASSPHRASE and is not stored. `ls` and `get` take --key-from <synced dir> so the bucket browsers read an added encrypted volume with the key already on this machine. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017XkM29BZuvUK5RBjQ1fmWx
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
darkspadez
marked this pull request as ready for review
October 22, 2026 23:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: encrypted volumes (#31) could only be created and attached from the command line. In the TUI or the Mac app, adding one failed with "this volume is encrypted", and their bucket browsers couldn't read one.
After: making a volume from a folder in either app takes an optional passphrase, entered twice, which encrypts the new volume. Adding a volume takes a passphrase for encrypted ones. The passphrase is handed to
rustfusefor that one command and is not stored, since each machine keeps the volume's key. The "In the Bucket" browsers read an added encrypted volume with the key already on this machine, without asking again.How:
rustfuse lsandgettake--key-from <synced dir>to use that directory's key instead of the passphrase. The TUI's add and create forms gain secret fields, and the apps passRUSTFUSE_PASSPHRASEand--encrypttorustfuse. The Mac app's sheets gain a SecureField, plus an "Encrypt with a passphrase" toggle when making a volume. The argument builders on both sides have tests. When run outside a terminal, the CLI's missing-passphrase error now names the variable to set.--key-fromwas checked by hand against rustFS.Generated by Claude Code