Skip to content

Sign and notarize Mac releases when the Apple secrets are set - #36

Draft
darkspadez wants to merge 1 commit into
mainfrom
claude/architecture-design-3fxhjv
Draft

darkspadez wants to merge 1 commit into
mainfrom
claude/architecture-design-3fxhjv

Conversation

@darkspadez

Copy link
Copy Markdown
Contributor

Before: Mac release binaries were unsigned, and there was no way to ship the Mac app. Its File Provider and FSKit extensions only load when signed by a team.

After: once the Apple signing secrets are added to the repository, a release tag also:

  • signs rustfuse and rustfuse-macfuse with Developer ID and notarizes them,
  • builds the Mac app, signs it with Developer ID (using provisioning profiles for the app, the File Provider extension and the FSKit module), notarizes it, staples it, and attaches rustFUSE-<version>.zip to the release.

Without the secrets, nothing changes: the jobs print a notice and skip. If only some secrets are set, they fail and list which are missing.

How:

  • macos/sign.sh uses a throwaway keychain, installs the profiles, and does a manual-signing archive and Developer ID export, then notarytool and stapler.
  • Per-target PROVISIONING_PROFILE_SPECIFIER settings come from xcconfig variables that are empty by default.
  • bundle-daemon.sh now signs the bundled helpers with a secure timestamp in Release builds, which notarization requires.
  • macos/README.md has the one-time Apple account setup and the list of secrets.

None of this can run until the Apple Developer account exists, so the signing path itself is unverified. The CI run on this PR only exercises the "no secrets" path.


Generated by Claude Code

macos/sign.sh signs the Mac command line tools and the app with Developer
ID (manual signing with provisioning profiles for the app, the File
Provider extension and the FSKit module), notarizes them with an App
Store Connect API key and staples the app. The release workflow runs it
when the secrets exist and attaches rustFUSE-<version>.zip; without them
nothing changes. Release builds sign the bundled helpers with a secure
timestamp, which notarization needs.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017XkM29BZuvUK5RBjQ1fmWx
@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants