Repository navigation
Sign and notarize Mac releases when the Apple secrets are set - #36
Draft
darkspadez wants to merge 1 commit into
Draft
darkspadez wants to merge 1 commit into
darkspadez wants to merge 1 commit into
Conversation
macos/sign.sh signs the Mac command line tools and the app with Developer ID (manual signing with provisioning profiles for the app, the File Provider extension and the FSKit module), notarizes them with an App Store Connect API key and staples the app. The release workflow runs it when the secrets exist and attaches rustFUSE-<version>.zip; without them nothing changes. Release builds sign the bundled helpers with a secure timestamp, which notarization needs. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017XkM29BZuvUK5RBjQ1fmWx
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: Mac release binaries were unsigned, and there was no way to ship the Mac app. Its File Provider and FSKit extensions only load when signed by a team.
After: once the Apple signing secrets are added to the repository, a release tag also:
rustfuseandrustfuse-macfusewith Developer ID and notarizes them,rustFUSE-<version>.zipto the release.Without the secrets, nothing changes: the jobs print a notice and skip. If only some secrets are set, they fail and list which are missing.
How:
macos/sign.shuses a throwaway keychain, installs the profiles, and does a manual-signing archive and Developer ID export, thennotarytoolandstapler.PROVISIONING_PROFILE_SPECIFIERsettings come from xcconfig variables that are empty by default.bundle-daemon.shnow signs the bundled helpers with a secure timestamp in Release builds, which notarization requires.macos/README.mdhas the one-time Apple account setup and the list of secrets.None of this can run until the Apple Developer account exists, so the signing path itself is unverified. The CI run on this PR only exercises the "no secrets" path.
Generated by Claude Code