Repository navigation
Fix prs for repos without config showing error - #34
Merged
Merged
Conversation
lucasmerlin
commented
Oct 9, 2026
lucasmerlin
commented
Member
There was a problem hiding this comment.
🟢 Approval recommended
The focused change correctly fixes lost HTTP status information without introducing unresolved issues.
0 open findings
What changed in this PR
Preserves upstream HTTP status codes in the WASM transport so repository configuration errors are handled correctly.
Changes:
- Copies the
reqwestresponse status into the returned HTTP response. - Continues preserving response headers and body.
| File | Description |
|---|---|
crates/octocrab-wasm/src/reqwest_tower_service.rs |
Propagates the upstream HTTP status. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Wumpf
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.