Repository navigation
Conversation
Fill was accidentally defined in slice_example_test.go instead of slice.go, causing it to not be exported as part of the public mutable package. This moves func Fill into slice.go, adds ExampleFill() in slice_example_test.go, and updates the source reference and example in docs/data/mutable-fill.md.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
In the
mutablepackage,func Fillwas accidentally declared insidemutable/slice_example_test.goinstead ofmutable/slice.go.Because Go omits
_test.gofiles during compilation for external consumers,mutable.Fillwas not actually exported in the public API when importinggithub.com/samber/lo/mutable(undefined: mutable.Fill).Changes made:
func Fill: Moved frommutable/slice_example_test.gotomutable/slice.go.ExampleFill: Added a runnableExampleFill()inmutable/slice_example_test.goto verify the example and keep documentation examples complete.sourceRefindocs/data/mutable-fill.mdto point tomutable/slice.go#L78.docs/data/mutable-fill.mdto uselom.Fillinstead oflo.Fill.Verification:
go doc ./mutablenow correctly lists: