Repository navigation
Resample: accept a plain dict for method_overrides - #242
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #241
Stacked on #240, which is stacked on #239. GitHub retargets it when those merge.
Grid.resample(method_overrides={...})crashed in the client withAttributeError: 'dict' object has no attribute 'to_dict', because the generatedCreateResampleRequestonly serializes aCreateResampleRequestMethodOverridesinstance.Changes
_build_method_overrides(new, private), used byresample:Nonesends nothingCreateResampleRequestMethodOverridesinstance is passed through unchangedResamplingMethod, then is converted withCreateResampleRequestMethodOverrides.from_dictValueErrorA bad method raises
ValueErrorbefore any request, and the message names the band. This matches the other mapping-or-model builders:_build_chm_spike_filter,_build_boundary_scatter,_build_crown_segmentation.Docstring:
method_overridesis documented asMapping[str, str], with an example and a Raises entry.Tests (
tests/v2/test_grids.py,TestResample):{"aspect": "nearest"}that checks the storedsource.method_overridesCompatibility
Not breaking: an existing
CreateResampleRequestMethodOverridesargument still works.Verification
pytest tests/v2/test_grids.py -k TestResampleagainst prod: 21 passed. The live test checks that prod stores the overrides; it doesn't run the resample job.