Repository navigation
Fix GeoTIFF upload example and document band quantities - #243
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #236
Already on main from #239: the client regen (
UploadBandDefinition.type_/unitnow optional) and the Fosberg band rename tofuel_moisture.1hrin thecreate_dead_fuel_moisture_grid_from_fosbergdocstring,docs/v2/guides/creating-grids.md, and the live test.This PR:
creating-grids.md:UploadBandDefinitionhas nointerpolationargument; the example is nowUploadBandDefinition(key="elevation"), with prose explaining the<quantity>/<quantity>.<label>key and that type and unit are derived from the quantity.create_grid_from_geotiffdocstring (create_grid_from_netcdftakes no band definitions, so unchanged).type_and assert the derived type (continuous) and unit (m).Verification:
pytest tests/v2/test_grids.py -k "geotiff or netcdf or upload"against prod: 1 passed, 1 skipped (NetCDF test is skipped in the suite).