Repository navigation
Point the v2 client at https://api.fastfuels.silvxlabs.com - #249
Merged
Merged
Conversation
The v2 API now serves every route under /v2 behind the load balancer (silvxlabs/FastFuels-API-v2#669). Regenerate the client from /v2/openapi.json, so the generated paths carry /v2, and use the host as DEFAULT_BASE_URL, the same shape as the v1 client. generate_client.sh reads the spec from $URL/v2/openapi.json, or from a local file given as OPENAPI_SPEC. The regen also drops the removed `/` index endpoint and picks up the new links.create.href description.
amarcozzi
marked this pull request as ready for review
November 3, 2026 15:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #185
What changes
DEFAULT_BASE_URLis nowhttps://api.fastfuels.silvxlabs.com: the host only. The v2 API serves every route under/v2(Serve the v2 API under the /v2 path prefix FastFuels-API-v2#669), so the paths in the OpenAPI spec, and in the regenerated client, carry/v2(/v2/domains, ...). This matches the v1 client: hosthttps://api.fastfuels.silvxlabs.com, paths under/v1./v2path prefix on every endpoint (the index endpoint moves from/to/v2) and updatedlinks.create.hrefdescriptions.generate_client.shfetches$URL/v2/openapi.json. It can also read a local spec throughOPENAPI_SPEC, which is how this regen was done before #669 deploys.#185's title says
.../v2as the base URL. The API team chose host +/v2paths instead, so a plain regen never doubles the prefix.Compatibility
FASTFUELS_API_V2_URLstill overrides the base URL. Set it to a host (e.g. a localhttp://127.0.0.1:8080), not to a URL ending in/v2, or the prefix is doubled.Merge order
https://api.fastfuels.silvxlabs.com/v2/...returns 404, so this PR's live CI fails.bash fastfuels_sdk/v2/generate_client.sh); it should give no diff.Verification
Against the #669 branch on a local server (
FASTFUELS_API_V2_URL=http://127.0.0.1:8080):tests/v2/test_api.py,test_domains.pyandtest_exceptions.pypass (35 tests). The server log shows all 46 requests on/v2/....