Repository navigation
Conversation
Since v0.25.0 the v2 tests reach the API through the load balancer, so they count against Cloud Armor's per-IP throttle. The test client now sends X-FastFuels-CI from FASTFUELS_CI_BYPASS, which Armor exempts.
amarcozzi
force-pushed
the
ci-armor-header
branch
from
November 3, 2026 15:23
305c4f4 to
25a6922
Compare
Contributor
Author
|
Not needed: Cloud Armor no longer exempts CI by header. The per-IP throttle moves to 1000/min, above CI's peak (silvxlabs/FastFuels-IaC#26), so the v2 tests need no header or secret. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Since v0.25.0 the v2 tests reach
https://api.fastfuels.silvxlabs.com, so CI's requests now count against Cloud Armor's 600 requests/min per-IP throttle. The throttle is in preview today; once it's enforced, a busy run could get 429s.tests/v2/utils.py:install_skip_dispatch_clientnow addsX-FastFuels-CIto both test clients: the default one, which also carries the skip-dispatch header, and the real-dispatch one. The value comes fromFASTFUELS_CI_BYPASS, which Armor's priority-1000 rule exempts from the throttle. When the variable is unset, no header is sent, so local runs and fork PRs are unchanged.tests_main.yml: the v2 test job passessecrets.FASTFUELS_CI_BYPASS.v1 tests aren't changed. They run only when v1 code changes, and their volume is far below the limit.
Before merging
Add the repo secret
FASTFUELS_CI_BYPASS, with the same value as FastFuels-API-v2's, fromterraform output -raw ci_bypass_header_valuein FastFuels-IaCstacks/edge.Verification
With dummy values, the default client sends
X-FastFuels-CIandX-FastFuels-Skip-Dispatch, the real-dispatch client sendsX-FastFuels-CI, and with no secret only the skip-dispatch header is sent.