Repository navigation
CB-305: bugfix: add padding to OUI bytes in PDID reports - #46
Merged
Merged
Conversation
Nedap's vendor OUI (as generated by the test Lumo on 11/2026) is `00-0D-0A`, which was being read in the generation of ID reports as `0DA` due to a lack of padding logic in `Jeff.Reply.IdReport`. This expands the `hex` helper function to include padding the resultant string with leading zeroes.
Halophilus
marked this pull request as ready for review
November 3, 2026 16:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nedap's vendor OUI (as generated by the test Lumo on 11/2026) is
00-0D-0A, which was being read in the generation of ID reports as0DAdue to a lack of padding logic inJeff.Reply.IdReport. This expands thehexhelper function to include padding the resultant string with leading zeroes.