Skip to content

examples: liveQuery implies live(); router 2.0.0-next.42 - #4219

Merged
ryansolid merged 1 commit into
nextfrom
claude/project-thread-8ayzle
Oct 22, 2026
Merged

ryansolid merged 1 commit into
nextfrom
claude/project-thread-8ayzle

Conversation

@ryansolid

Copy link
Copy Markdown
Member

Requested by Ryan · project thread

Summary

Router 2.0.0-next.42 (solidjs/solid-router#690) declares a server function producer live() inside liveQuery. This PR follows that in the examples:

  • examples/chat: getThreads and getThread drop the liveQuery(live(fn), key) wrapper, and the now-unused live imports go with it. The thread comment, the README and the simulated model's canned answer about server components are reworded to match.
  • All examples are pinned to @solidjs/router 2.0.0-next.42, and the lockfile is regenerated with pnpm install.

server-dbmon keeps liveQuery(broadcast(fn)), because broadcast already declares live.

I lengthened the canned answer by one sentence, which says that liveQuery declares the function live. The reason: chat's check:server asserts that a reply yields more than 5 times, and removing the two live( lines alone dropped that count to exactly 5.

How did you test this change?

  • pnpm run build at the root, then examples/chat: pnpm run typecheck and pnpm run check (all server checks ok; client bundle clean).
  • examples/server-dbmon and examples/hackernews: pnpm run build succeeds against next.42.

Generated by Claude Code

Drop the liveQuery(live(fn)) wrapper in the chat example now that router
next.42 declares server function producers live() itself, and pin every
example to router next.42.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fmb4aQtDJWoA8CUktR9QoZ
@changeset-bot

changeset-bot Bot commented Oct 22, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 727f256

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ryansolid ryansolid self-assigned this Oct 22, 2026
@github-actions

Copy link
Copy Markdown

Size (brotli, eager entry chunk)

scenario head vs base minified vs base minified vs recorded cap lazy chunks (not counted)
signals: core floor (createSignal/Memo/Effect/Root/flush) 7.42 KB 0 B 0 B 0 B 7.44 KB ✅
signals: + createStore 15.03 KB 0 B 0 B 0 B 15.04 KB ✅
signals: + isPending/latest 10.28 KB 0 B 0 B 0 B 10.30 KB ✅
signals: + until/refresh (truth readers, no optimism) 8.04 KB 0 B 0 B 0 B 8.05 KB ✅
app: render + one signal (the simple-app floor) 9.73 KB 0 B 0 B 0 B 9.75 KB ✅
app: hydrating (no stores) with Show/For/Loading/Errored/lazy 18.40 KB 0 B 0 B +4 B 18.38 KB ⚠️ over by 17 B, 16 B minified headroom lazy-page.js 0.04 KB
app: hydrating + every store primitive family 30.67 KB 0 B 0 B +4 B 30.66 KB ⚠️ over by 12 B, 16 B minified headroom lazy-page.js 0.04 KB
app: CSR with Show/For/Loading/Errored/lazy 13.32 KB 0 B 0 B +4 B 13.33 KB ✅ lazy-page.js 0.04 KB
app: CSR, observe tier (same app on the observe artifacts) 15.08 KB 0 B 0 B +4 B 15.08 KB ✅ lazy-page.js 0.04 KB
app: CSR, observe tier + attribution engine enabled 29.61 KB 0 B 0 B +4 B 29.64 KB ✅ lazy-page.js 0.04 KB
app: compiled floor (one template, one text hole, one delegated click) 9.92 KB 0 B 0 B 0 B 9.93 KB ✅
app: compiled CSR (JSX todo app: spread/merge/omit, events, class/style, keyed For, Show, Loading + lazy, store) 26.23 KB 0 B 0 B +4 B 26.23 KB ⚠️ over by 4 B, 16 B minified headroom stats.js 0.18 KB
app: compiled hydrating (the same JSX todo app through hydrate(), compiled hydratable) 32.14 KB 0 B 0 B +4 B 32.23 KB ✅ stats.js 0.20 KB
frames: eager client consumer (frames client + transport, lazy codec) 11.75 KB 0 B 0 B 0 B 11.76 KB ✅
page: base server components (hydrating + dynamic + frames + sf reference) 33.24 KB 0 B 0 B +12 B 33.27 KB ✅ assets.js 0.78 KB, decode.js 6.25 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.10 KB, wire.js 2.78 KB
page: live server components (base + live/GET + action + isPending/latest) 37.63 KB 0 B 0 B +4 B 37.64 KB ✅ assets.js 0.78 KB, decode.js 6.25 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.09 KB, wire.js 2.78 KB
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread) 35.26 KB 0 B 0 B +12 B 35.30 KB ✅ assets.js 0.78 KB, decode.js 6.25 KB, regions.js 1.06 KB, sc-comments.js 0.20 KB, trace.js 9.09 KB, wire.js 2.77 KB
page: compiled live server components (the compiled base page + live/GET + action + isPending/latest) 41.45 KB 0 B 0 B +4 B 41.47 KB ✅ eager (counted): web.js 22.05 KB; assets.js 0.78 KB, decode.js 6.25 KB, regions.js 1.06 KB, sc-comments.js 0.19 KB, trace.js 9.13 KB, wire.js 2.77 KB
page: base + router (base page + @solidjs/router: createRouter, two routes, preload, useNavigate) 40.70 KB 0 B 0 B +4 B 40.78 KB ✅ assets.js 0.78 KB, decode.js 6.25 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, server.js 1.02 KB, serverForms.js 3.58 KB, trace.js 9.14 KB, wire.js 2.77 KB
page: live + router (live page + @solidjs/router: createRouter, two routes, preload, useNavigate) 46.99 KB 0 B 0 B +4 B 47.01 KB ✅ eager (counted): client.js 27.17 KB; assets.js 0.78 KB, decode.js 6.25 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.02 KB, serverForms.js 3.32 KB, trace.js 9.14 KB, wire.js 2.80 KB
server: floor (getRequestEvent + isServer) 1.33 KB 0 B 0 B 0 B 1.34 KB ✅
server: renderToString (the server-render floor) 20.63 KB 0 B 0 B 0 B 20.65 KB ✅

⚠️ Over the brotli cap within the minified allowance (passes)

  • app: hydrating (no stores) with Show/For/Loading/Errored/lazy: over brotli cap by 17 B; minified 53,602 B vs 53,598 B recorded with the cap (+4 B) — 16 B of the 20 B minified allowance left; +0 B minified over this PR's base
  • app: hydrating + every store primitive family: over brotli cap by 12 B; minified 95,841 B vs 95,837 B recorded with the cap (+4 B) — 16 B of the 20 B minified allowance left; +0 B minified over this PR's base
  • app: compiled CSR (JSX todo app: spread/merge/omit, events, class/style, keyed For, Show, Loading + lazy, store): over brotli cap by 4 B; minified 81,331 B vs 81,327 B recorded with the cap (+4 B) — 16 B of the 20 B minified allowance left; +0 B minified over this PR's base

Bundled with Rolldown (what Vite ships), brotli q11, decimal KB. A scenario fails only when it is over its brotli cap and its minified size is more than 20 B over the minified recorded with the cap; over the cap within that allowance is brotli layout noise and passes with a warning. Caps and their recorded minified in scripts/size/scenarios.js; the floor and page caps in floor-caps.json are frozen (lower only, or Size-Exception: in the PR body). npm run ratchet lowers caps per RC; it never raises one (scripts/size/README.md).

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 39752451285

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage remained the same at 77.662%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 1349
Covered Lines: 1105
Line Coverage: 81.91%
Relevant Branches: 1055
Covered Branches: 762
Branch Coverage: 72.23%
Branches in Coverage %: Yes
Coverage Strength: 27.49 hits per line

💛 - Coveralls

@codspeed

codspeed Bot commented Oct 22, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning

⚠️ 3 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 196 untouched benchmarks
⏩ 5 skipped benchmarks1


Comparing claude/project-thread-8ayzle (727f256) with next (5b1b777)

Open in CodSpeed

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@ryansolid
ryansolid merged commit 3f85df1 into next Oct 22, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants