Repository navigation
examples: liveQuery implies live(); router 2.0.0-next.42 - #4219
Conversation
Drop the liveQuery(live(fn)) wrapper in the chat example now that router next.42 declares server function producers live() itself, and pin every example to router next.42. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fmb4aQtDJWoA8CUktR9QoZ
|
Size (brotli, eager entry chunk)
|
Coverage Report for CI Build 39752451285Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage remained the same at 77.662%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Merging this PR will not alter performance1 warning
Comparing Footnotes
|
Requested by Ryan · project thread
Summary
Router 2.0.0-next.42 (solidjs/solid-router#690) declares a server function producer
live()insideliveQuery. This PR follows that in the examples:examples/chat:getThreadsandgetThreaddrop theliveQuery(live(fn), key)wrapper, and the now-unusedliveimports go with it. The thread comment, the README and the simulated model's canned answer about server components are reworded to match.@solidjs/router2.0.0-next.42, and the lockfile is regenerated withpnpm install.server-dbmonkeepsliveQuery(broadcast(fn)), becausebroadcastalready declareslive.I lengthened the canned answer by one sentence, which says that
liveQuerydeclares the functionlive. The reason: chat'scheck:serverasserts that a reply yields more than 5 times, and removing the twolive(lines alone dropped that count to exactly 5.How did you test this change?
pnpm run buildat the root, thenexamples/chat:pnpm run typecheckandpnpm run check(all server checks ok; client bundle clean).examples/server-dbmonandexamples/hackernews:pnpm run buildsucceeds against next.42.Generated by Claude Code