Repository navigation
Conversation
Enz000
force-pushed
the
fix-toolkit-navigation-menu-screenshots
branch
from
October 14, 2026 10:13
486dd8f to
04e2839
Compare
Enz000
changed the title
Contributor
Author
|
"Unit Tests / php (dev, 8.5) (pull_request)" fail also, here's the fix #4095 |
…a whole pixel | Q | A | -------------- | --- | Bug fix? | yes | New feature? | no | Deprecations? | no | Documentation? | no | Issues | | License | MIT Since the update to Playwright 1.64, the "opens on hover" and "still opens after being moved in the DOM" screenshots of `navigation-menu` fail about one run in two. This breaks the `browser (8/8)` job, on 3.x and on every pull request. The panel is anchored to the inline-start of its trigger. In the default example, the menu is centered and has a fractional width, so the panel starts at x = 204.156. Text placed on a fractional pixel is not rasterized the same way every time: two renderings alternate, and they differ on the antialiasing of the item titles. The panel of the "Resources" item lands on x = 284, a whole pixel, and its screenshot never fails. The controller now rounds the edge of the panel to a whole pixel. In the RTL example, the right edge moves from 451.984 to 452. On a screen with a whole device pixel ratio, such as 2, a whole CSS pixel is also a whole device pixel. Rounding to the device pixel itself would need `window.devicePixelRatio`, which is not Baseline Widely available. Checks run: - A new test checks that the edge of the open panel lies on a whole pixel, in the default and RTL examples. It fails without the change (204.15625 and 451.984375). - Before the change, the four flaky screenshot tests passed 19 times out of 40. After it, the eight screenshot tests that open the menu pass 80 times out of 80. - The full spec of the recipe passes (24 tests). Three screenshots are updated, by about 0.16 px. - `oxfmt`, `oxlint` and `lint:baseline` are clean.
Enz000
force-pushed
the
fix-toolkit-navigation-menu-screenshots
branch
from
October 15, 2026 09:39
04e2839 to
07fe07c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the update to Playwright 1.64, the "opens on hover" and "still opens after being moved in the DOM" screenshots of
navigation-menufail about one run in two. This breaks thebrowser (8/8)job, on 3.x and on every pull request.The panel is anchored to the inline-start of its trigger. In the default example, the menu is centered and has a fractional width, so the panel starts at x = 204.156. Text placed on a fractional pixel is not rasterized the same way every time: two renderings alternate, and they differ on the antialiasing of the item titles. The panel of the "Resources" item lands on x = 284, a whole pixel, and its screenshot never fails.
The controller now snaps the edge of the panel to a device pixel, as Floating UI does by default. In the RTL example, the right edge moves from 451.984 to 452.
Checks run:
oxfmtandoxlintare clean.