Repository navigation
Measure the HAM left border clear from its start pointer - #622
Merged
Merged
Conversation
The fast-mode HAM left-border clear starts at buf1p, but its length was clamped with the advanced output cursor buf1. With full_line_draw (for example genlock) draw_blank_end() has already moved buf1 to xlinebuffer_end, so the clear was always skipped; otherwise it could be cut short by the unrelated space left at the right edge. Clamp against the remaining space from buf1p.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fast-mode HAM left-border clear starts at buf1p, but its length was
clamped with the advanced output cursor buf1. With full_line_draw (for
example genlock) draw_blank_end() has already moved buf1 to
xlinebuffer_end, so the clear was always skipped; otherwise it could be
cut short by the unrelated space left at the right edge. Clamp against
the remaining space from buf1p.
Found while porting 45d7458 to Amiberry (BlitterStudio/amiberry#2595), which has the same fix.