Repository navigation
Start the x86 Sound Blaster settings sentinel at -1 - #630
Merged
Merged
Conversation
x86_global_settings is static and started at 0, and set_sb_emu() returns before assigning it when no Sound Blaster is configured. x86_device_config() then took the Sound Blaster branch for every query and returned before the PS/2 mouse "buttons" override, so a selected IntelliMouse came up as a two-button mouse without wheel support. Start the sentinel at -1 and answer the mouse query before the Sound Blaster settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x86_global_settings is static and started at 0, and set_sb_emu() returns before assigning it when no Sound Blaster is configured. x86_device_config() then took the Sound Blaster branch for every query and returned before the PS/2 mouse "buttons" override, so a selected IntelliMouse came up as a two-button mouse without wheel support. Start the sentinel at -1 and answer the mouse query before the Sound Blaster settings.
Found while porting the 86Box import to Amiberry (BlitterStudio/amiberry#2599), which has the same fix.