Repository navigation
test: hasBatchim, josa, removeLastCharacter에 비한글 문자 경계 케이스 테스트 추가 - #410
Open
Choi-Jung-Hyeon wants to merge 1 commit into
Open
Choi-Jung-Hyeon wants to merge 1 commit into
Choi-Jung-Hyeon wants to merge 1 commit into
Conversation
Related toss#194 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
#194 관련 작업이에요. 아직 PR 없는
hasBatchim,josa,removeLastCharacter에 영어, 특수문자, 다른 언어, 공백 케이스 테스트를 추가했어요.hasBatchim: 마지막 글자가 한글이 아니면falsejosa: 마지막 글자가 한글이 아니면 받침 없는 쪽 조사를 붙임 (apple가). 대문자 약어(URL이)는 기존 테스트가 있어서 그 외 경우만 추가했어요.removeLastCharacter: 마지막 글자가 한글이 아니면 그 글자를 그대로 지움질문
테스트를 쓰다가 본 동작 두 가지예요. 둘 다 테스트로 고정하지 않았고, 의도된 게 아니면 별도 이슈로 올릴게요.
removeLastCharacter('😀')가'\ud83d'(반쪽 문자)를 반환해요.words[words.length - 1]로 마지막 코드 유닛만 잘라서 생기는 것 같아요.josa에만 있고josa.pick에는 없어요.PR Checklist
🤖 Generated with Claude Code