Skip to content

test: hasBatchim, josa, removeLastCharacter에 비한글 문자 경계 케이스 테스트 추가 - #410

Open
Choi-Jung-Hyeon wants to merge 1 commit into
toss:mainfrom
Choi-Jung-Hyeon:test/edge-case-specs-194-part3
Open

Choi-Jung-Hyeon wants to merge 1 commit into
toss:mainfrom
Choi-Jung-Hyeon:test/edge-case-specs-194-part3

Conversation

@Choi-Jung-Hyeon

Copy link
Copy Markdown

Overview

#194 관련 작업이에요. 아직 PR 없는 hasBatchim, josa, removeLastCharacter에 영어, 특수문자, 다른 언어, 공백 케이스 테스트를 추가했어요.

  • hasBatchim: 마지막 글자가 한글이 아니면 false
  • josa: 마지막 글자가 한글이 아니면 받침 없는 쪽 조사를 붙임 (apple가). 대문자 약어(URL이)는 기존 테스트가 있어서 그 외 경우만 추가했어요.
  • removeLastCharacter: 마지막 글자가 한글이 아니면 그 글자를 그대로 지움

질문

테스트를 쓰다가 본 동작 두 가지예요. 둘 다 테스트로 고정하지 않았고, 의도된 게 아니면 별도 이슈로 올릴게요.

  1. removeLastCharacter('😀')가 '\ud83d'(반쪽 문자)를 반환해요. words[words.length - 1]로 마지막 코드 유닛만 잘라서 생기는 것 같아요.
  2. 대문자 약어 처리가 josa에만 있고 josa.pick에는 없어요.
josa('URL', '이/가'); // 'URL이'
josa.pick('URL', '이/가'); // '가'

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

🤖 Generated with Claude Code

@changeset-bot

changeset-bot Bot commented Nov 12, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: fe58006

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
es-hangul Error Error Nov 12, 2026 5:19am UTC

Request Review

This branch had an error being deployed

1 failed deployment
Preview — fe580064 Deployed Nov 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant