Skip to content

[Bugfix] Revert MetalKernelsStaleCheck build plugin - #1385

Merged
untoldengine merged 1 commit into
developfrom
issue/1384
Oct 23, 2026
Merged

untoldengine merged 1 commit into
developfrom
issue/1384

Conversation

@untoldengine

Copy link
Copy Markdown
Owner

Summary

  • Reverts Warn at build time when Metal kernel sources are stale #1357 (commit 5cf2229), removing the MetalKernelsStaleCheck SwiftPM build-tool plugin and its stamp-writing hook in buildkernels.sh.
  • In Xcode, the plugin triggers a malicious-code warning that must be manually trusted/approved, which is disruptive enough to warrant removing it.

Follow-up

We'll need another way to catch stale .metallib builds, since this was the problem #1357 was originally solving (closes #1351).

Closes #1384

Test plan

  • git diff matches an exact revert of Package.swift / buildkernels.sh
  • Confirm Xcode no longer prompts for plugin trust on a clean checkout

Reverts commit 5cf22298861a90edc9eb070dd384b1cf09a5d170f (#1357). The build-tool plugin triggers Xcode's malicious-code warning, requiring manual trust approval, which is disruptive enough to warrant removing it. A different mechanism will be needed to catch stale .metallib builds.

Closes #1384
@untoldengine
untoldengine merged commit 4096c38 into develop Oct 23, 2026
4 checks passed
@untoldengine
untoldengine deleted the issue/1384 branch October 23, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant