Repository navigation
Clean up v5 SDK dependencies - #2800
Merged
Merged
Conversation
olanod
marked this pull request as ready for review
November 6, 2026 11:19
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v5.x #2800 +/- ##
=======================================
Coverage ? 71.42%
=======================================
Files ? 150
Lines ? 15830
Branches ? 260
=======================================
Hits ? 11307
Misses ? 4523
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up to #2799. The call-runtime example only needs one address variant, so it no longer pulls in
sp-runtimeandsp-io. Its public API and encoded calls stay the same. Also removes a few redundant dependency declarations.Keep UAPI 9 for existing contracts: newer bindings change
CallFlags::all()and drop RISC-V support.Checks
Workspace checks at
c6bf33ec(workspace code unchanged since):cargo test --workspace --all-features --locked: 522 passed, 10 ignored, with the sameQUICKCHECK_TESTS=0setting as CI.cargo clippy --workspace --all-targets --all-features --locked -- -D warnings: passed.inkon host and no-std Wasm: passed.Final example at
17813e7c:cargo test --manifest-path integration-tests/public/call-runtime/Cargo.toml --all-features: all three E2E tests passed against substrate-contracts-node 0.41.Example Clippy (
--all-targets --all-features --locked -- -D warnings) passed.Public metadata (methods, types and storage) matches the original example.
Formatting, manifest checks and locked lint-workspace dependency resolution passed.
At
440202b4,cargo contract build --release --manifest-path integration-tests/public/call-runtime/Cargo.tomlpassed with the maintained v5 tool; the SCALE-generated index cast has the same scoped lint allowance as the adjacent enums.Independent code review passed. CI is still running.