Repository navigation
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
lahfir
force-pushed
the
laf/bidi-attach
branch
from
October 27, 2026 02:38
4744f8e to
e7f1346
Compare
lahfir
force-pushed
the
laf/bidi-attach
branch
from
October 27, 2026 03:03
e7f1346 to
f61ae72
Compare
lahfir
force-pushed
the
laf/bidi-attach
branch
from
October 27, 2026 03:33
f61ae72 to
dc8bdaa
Compare
ctate
approved these changes
Oct 27, 2026
lahfir
force-pushed
the
laf/bidi-attach
branch
from
October 27, 2026 19:31
dc8bdaa to
42f8784
Compare
ctate
approved these changes
Oct 27, 2026
ctate
approved these changes
Oct 27, 2026
ctate
approved these changes
Nov 7, 2026
Use owner_tab for destroyed-tab cleanup and match the restored option validation test to the attach-aware signature.
ctate
reviewed
Nov 8, 2026
…ndoes it on close
Destroyed tabs go through the context owner so the active tab falls back to a survivor, and the launch validator stays connection-aware.
ctate
approved these changes
Nov 8, 2026
ctate
approved these changes
Nov 8, 2026
ctate
reviewed
Nov 9, 2026
| .to_string(), | ||
| ); | ||
| } | ||
| let context = contexts |
Collaborator
There was a problem hiding this comment.
Attach adopts the first browsingContext.getTree tab and never checks which tab is selected, so with several tabs open commands act on the oldest tab and the first snapshot activates it in the user's window. Reproduced.
ctate
reviewed
Nov 10, 2026
| continue; | ||
| } | ||
| let external_firefox = key == Key::Engine && value.as_str() == Some("firefox"); | ||
| let external_firefox = key == Key::Engine |
Collaborator
There was a problem hiding this comment.
Only Engine is exempted from the local-only rule, so --user-agent is ignored on an attached Firefox: agent-browser --user-agent X open ... after connect leaves Firefox's own UA unchanged, though the attach docs say it applies. Reproduced.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connectand--cdponly spoke CDP, so agent-browser could not attach to a Firefox that was already running.firefox-attach.mp4