Repository navigation
Conversation
Chromium 157 removed the WebMCPTesting feature alias, so the managed launch no longer exposed WebMCP: the discovery test saw a null WebMCP field and the fixture's registerTool call failed on an undefined document.modelContext. Enable the WebMCP feature directly in the WebMCP launch branch. The legacy WebMCPTesting flag stays so older managed Chrome builds keep working. The launch-args unit tests now assert the exact WebMCP token is present by default and absent with --no-webmcp. Fixes vercel-labs#2513
Contributor
|
@sx4im is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
I ran a focused Ubuntu comparison for #2513 on upstream Linux run and logs. This verifies the flag change in isolation, not this PR's exact head, the whole E2E suite, or older Chrome releases. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Managed Chrome 157 launches still pass WebMCPTesting, which Chromium 157 removed, so WebMCP never gets enabled. The discovery test then sees a null WebMCP field and the fixture fails registering tools on an undefined document.modelContext.
This enables the WebMCP feature directly in the WebMCP launch branch. The legacy WebMCPTesting flag stays so older managed Chrome builds keep working. The launch-args unit tests now assert the exact WebMCP token is present by default and absent with --no-webmcp.
Verified: the new unit-test assertions fail against the old flag list and pass against the new one (checked with a standalone run of the same token logic), and cargo fmt is clean. I could not run the cargo test suite locally: the build was killed twice by the sandbox running out of memory, and a runtime restart wiped the build cache. CI is the gate for the unit tests and the Chrome 157 discovery test.
Fixes #2513